Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Commit 6edfba5

Browse files
committed
Merge pull request #18 from cfieber/master
add dependenciesVersion to spinnaker extension
2 parents d8ca687 + db746f4 commit 6edfba5

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ apply plugin: 'spinnaker.project'
3131

3232
The spinnaker extension exposes dependency resolution utilities. By default the artifact
3333
'com.netflix.spinnaker:spinnaker-dependencies:latest.release@yml' is resolved and used as
34-
common dependency configuration (this can be overridden by setting `dependenciesYaml` on the
35-
spinnaker extension).
34+
common dependency configuration (this can be overridden by setting `dependenciesYaml` or
35+
`dependenciesVersion` on the spinnaker extension)
3636

3737
The dependency yaml format supports three sections:
3838
* versions - a map of name to version string

src/main/groovy/com/netflix/spinnaker/gradle/dependency/SpinnakerDependency.groovy

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package com.netflix.spinnaker.gradle.dependency
1818

1919
import groovy.text.SimpleTemplateEngine
2020
import groovy.text.Template
21+
import org.codehaus.groovy.runtime.GStringImpl
2122
import org.gradle.api.Project
2223
import org.gradle.api.artifacts.Dependency
2324
import org.yaml.snakeyaml.Yaml
@@ -29,7 +30,9 @@ import java.util.concurrent.locks.ReentrantLock
2930

3031
class SpinnakerDependency {
3132

32-
private static final String DEFAULT_DEPENDENCIES_YAML = 'com.netflix.spinnaker:spinnaker-dependencies:latest.release@yml'
33+
private static final String OVERRIDE_PROJECT_PROPERTY = 'spinnaker.dependenciesVersion'
34+
private static final String DEFAULT_DEPENDENCIES_VERSION = 'latest.release'
35+
private static final GString DEFAULT_DEPENDENCIES_YAML = "com.netflix.spinnaker:spinnaker-dependencies:${DEFAULT_DEPENDENCIES_VERSION}@yml"
3336
private final Project project
3437
private final Map dependencyConfig = [:]
3538
private final SimpleTemplateEngine templateEngine = new SimpleTemplateEngine()
@@ -40,6 +43,7 @@ class SpinnakerDependency {
4043

4144

4245

46+
public Object dependenciesVersion
4347
public Object dependenciesYaml
4448

4549
SpinnakerDependency(Project project) {
@@ -57,7 +61,10 @@ class SpinnakerDependency {
5761
return dependencyConfig
5862
}
5963

60-
def conf = project.configurations.detachedConfiguration(project.dependencies.create(dependenciesYaml ?: DEFAULT_DEPENDENCIES_YAML))
64+
String dependenciesVersion = project.hasProperty(OVERRIDE_PROJECT_PROPERTY) ? project.property(OVERRIDE_PROJECT_PROPERTY) : dependenciesVersion ?: DEFAULT_DEPENDENCIES_VERSION
65+
Object dependencyString = dependenciesYaml ?: new GStringImpl([dependenciesVersion] as Object[], DEFAULT_DEPENDENCIES_YAML.strings)
66+
67+
def conf = project.configurations.detachedConfiguration(project.dependencies.create(dependencyString))
6168

6269
Map config = conf.singleFile.withReader {
6370
return (Map) new Yaml().load(it)

0 commit comments

Comments
 (0)