Removed const_cast<char*>("literal").

Replaced it with strdup("literal") throughout the code.

Author: Moritz

src/ovf.cpp

@@ -48,13 +48,13 @@ catch( ... )
 void ovf_segment_initialize(struct ovf_segment * ovf_segment_ptr)
 try
 {
-    ovf_segment_ptr->title              = const_cast<char *>("");
-    ovf_segment_ptr->comment            = const_cast<char *>("");
+    ovf_segment_ptr->title              = strdup("");
+    ovf_segment_ptr->comment            = strdup("");
     ovf_segment_ptr->valuedim           = 0;
-    ovf_segment_ptr->valueunits         = const_cast<char *>("");
-    ovf_segment_ptr->valuelabels        = const_cast<char *>("");
-    ovf_segment_ptr->meshtype           = const_cast<char *>("");
-    ovf_segment_ptr->meshunit           = const_cast<char *>("");
+    ovf_segment_ptr->valueunits         = strdup("");
+    ovf_segment_ptr->valuelabels        = strdup("");
+    ovf_segment_ptr->meshtype           = strdup("");
+    ovf_segment_ptr->meshunit           = strdup("");
     ovf_segment_ptr->pointcount         = 0;
     ovf_segment_ptr->n_cells[0]         = 0;
     ovf_segment_ptr->n_cells[1]         = 0;

test/atomistic.cpp

@@ -3,7 +3,6 @@
 #include <ovf.h>
 #include <fmt/format.h>
 
-
 #include <iostream>
 #include <cstring>
 
@@ -15,8 +14,8 @@ void ovf_test_write(std::string filename, std::string meshtype, int ovf_extensio
     {
         // segment header
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - write");
-        segment->comment = const_cast<char *>("test write");
+        segment->title   = strdup("ovf test title - write");
+        segment->comment = strdup("test write");
         segment->valuedim   = 3;
 
         segment->n_cells[0] = 2;
@@ -65,8 +64,8 @@ void ovf_test_write(std::string filename, std::string meshtype, int ovf_extensio
     {
         // Append second
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - append");
-        segment->comment = const_cast<char *>("test append");
+        segment->title   = strdup("ovf test title - append");
+        segment->comment = strdup("test append");
         segment->valuedim = 3;
         segment->n_cells[0] = 2;
         segment->n_cells[1] = 2;

test/binary.cpp

@@ -152,8 +152,8 @@ TEST_CASE( "Mixed binary and CSV", "[mixed]" )
     {
         // segment header
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - write");
-        segment->comment = const_cast<char *>("test write csv");
+        segment->title   = strdup("ovf test title - write");
+        segment->comment = strdup("test write csv");
         segment->valuedim = 3;
         segment->n_cells[0] = 2;
         segment->n_cells[1] = 2;

test/simple.cpp

@@ -1,6 +1,7 @@
 #include <catch.hpp>
 
 #include <ovf.h>
+#include <cstring>
 
 #include <iostream>
 
@@ -24,8 +25,8 @@ TEST_CASE( "Write", "[write]" )
     {
         // segment header
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - write");
-        segment->comment = const_cast<char *>("test write");
+        segment->title   = strdup("ovf test title - write");
+        segment->comment = strdup("test write");
         segment->valuedim = 3;
         segment->n_cells[0] = 2;
         segment->n_cells[1] = 2;
@@ -56,8 +57,8 @@ TEST_CASE( "Write", "[write]" )
     {
         // segment header
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - append");
-        segment->comment = const_cast<char *>("test append");
+        segment->title   = strdup("ovf test title - append");
+        segment->comment = strdup("test append");
         segment->valuedim = 3;
         segment->n_cells[0] = 2;
         segment->n_cells[1] = 2;
@@ -88,10 +89,10 @@ TEST_CASE( "Write", "[write]" )
     {
         // segment header
         auto segment = ovf_segment_create();
-        segment->title = const_cast<char *>("ovf test title - append irregular mesh");
-        segment->comment = const_cast<char *>("an irregular mesh has different keywords than a rectangular one");
+        segment->title    = strdup("ovf test title - append irregular mesh");
+        segment->comment  = strdup("an irregular mesh has different keywords than a rectangular one");
         segment->valuedim = 3;
-        segment->meshtype = const_cast<char *>("irregular");
+        segment->meshtype = strdup("irregular");
         segment->pointcount = 4;
 
         // data