Merge pull request #84 from spring-media/PA-5238

feat PA-5238: extend renderAuthComponent interface to allow inline rendering

Author: eschmittel

.github/workflows/pull_request.yml

@@ -1,15 +1,6 @@
 name: Checks
 on:
   pull_request:
-  # we're doing the filtering for branches and actions in each step,
-  # this one here works not as expected and could be misleading
-#    branches:
-#      - migrating-to-yaml-syntax
-#      - master
-#    action:
-#      - opened
-#      - edited
-#      - synchronize
 
 env:
   GITHUB_TOKEN: ${{ secrets.PS_GITHUB_ACCESSTOKEN }}
@@ -20,12 +11,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout branch
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set Node.js 16
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: "16"
           cache: 'yarn'
@@ -35,37 +24,20 @@ jobs:
           npm config set //npm.pkg.github.com/:_authToken=$GITHUB_TOKEN
 
       - name: Install yarn
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
         run: yarn install --frozen-lockfile
 
       - name: yarn format-check
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
         run: yarn check
 
   build:
     name: Build
     runs-on: ubuntu-latest
     steps:
       - name: Checkout branch
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        uses: actions/[email protected]
-
-      - name: Checkout master
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        uses: actions/[email protected]
-        with:
-          ref: master
-
-      - name: Check merge
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        run: |
-          git config --global user.name "Spring Media CD"
-          git config --global user.email "[email protected]"
-          git merge ${{ github.event.pull_request.head.sha }} -m"prchecker" --stat
+        uses: actions/checkout@v4
 
       - name: Set Node.js 16
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: "16"
           cache: 'yarn'
@@ -75,13 +47,10 @@ jobs:
           npm config set //npm.pkg.github.com/:_authToken=$GITHUB_TOKEN
 
       - name: Install yarn
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
         run: yarn install --frozen-lockfile
 
       - name: Test yarn
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
         run: yarn test
 
       - name: Build yarn
-        if: github.event.action == 'opened' || github.event.action == 'edited' || github.event.action == 'synchronize'
         run: yarn build

.github/workflows/push_master.yml

@@ -13,10 +13,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set Node.js 16
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: "16"
           cache: 'yarn'
@@ -36,10 +36,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout branch
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Set Node.js 16
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: "16"
           cache: 'yarn'

src/ps-web-apis.ts

@@ -200,6 +200,7 @@ export interface WhoamiV1 {
      *
      * @param {Object} config - config container object
      * @param {HTMLElement} [config.container] - The HTML element in which the Wonderwall should be rendered in. default = overlay
+     * @param {boolean} [config.inlineRender] - Renders Wonderwall directly in container instead of as overlay. default = false
      * @param {Object} config.props - The props which will be passed to the Wonderwall web component.
      * @param {String} config.props.template - valid choices are "register" and "login"
      * @param {String} config.props.variant - variant of the brand that should be shown e.g bild or welt
@@ -255,6 +256,7 @@ export type WonderwallProps = {
 
 export interface AuthComponentConfig {
     container?: HTMLElement;
+    inlineRender?: boolean;
     props: WonderwallProps;
 }