bug: crash on PONG

pnwmatt · pnwmatt · commit 524fead7a26e · 2025-11-18T21:27:11.000-08:00
diff --git a/client/subscription/manager.go b/client/subscription/manager.go
@@ -482,7 +482,7 @@ func (m *Manager) readLoop() {
 
 		var msg Message
 		if string(data) == "PING" || string(data) == "PONG" {
-			return
+			continue
 		}
 		if err := json.Unmarshal(data, &msg); err != nil {
 			m.logger.Warn("Failed to unmarshal message", zap.Error(err))

Original file line number	Diff line number	Diff line change
`@@ -482,7 +482,7 @@ func (m *Manager) readLoop() {`
`482`	`482`
`483`	`483`	`var msg Message`
`484`	`484`	`if string(data) == "PING" \|\| string(data) == "PONG" {`
`485`		`- return`
	`485`	`+ continue`
`486`	`486`	`}`
`487`	`487`	`if err := json.Unmarshal(data, &msg); err != nil {`
`488`	`488`	`m.logger.Warn("Failed to unmarshal message", zap.Error(err))`