Collect renderings on context specified in WorkflowLayout.take #1424
Conversation
steve-the-edwards
force-pushed
the
sedwards/update-take-dispatcher-rules
branch
from
e370e97 to
86bc859
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
| "Collection dispatch should happen on the lifecycle's dispatcher." | ||
| withContext(collectionContext) { | ||
| require(Looper.myLooper() == Looper.getMainLooper()) { | ||
| "Collection dispatch should happen on the main thread!" |
| * @param [collectionContext] additional [CoroutineContext] we want for the coroutine that is | ||
| * launched to collect the renderings. This should not override the [CoroutineDispatcher][kotlinx.coroutines.CoroutineDispatcher] | ||
| * but may include some other instrumentation elements. | ||
| * launched to collect the renderings, can include a different dispatcher - but it should be |
There was a problem hiding this comment.
Suggested wording: "can include a different dispatcher - but we verify that it's a main thread dispatcher" And maybe explain why this restriction exists (naively I thought all of this stuff was immutable so it'd be safe to access them from any thread)
There was a problem hiding this comment.
This part is not for the runtime actually, this is where we collect the emitted renderings from the runtime and update the views that show them.
so we need to get main thread here to update those views.
The wording change is good though!
There was a problem hiding this comment.
...but we verify that it is a main thread dispatcher since we are updating views here!
| unoriginal.show(BScreen(), env) | ||
| } | ||
|
|
||
| @Test fun usesLifecycleDispatcher() { |
There was a problem hiding this comment.
Do we have any test coverage now? If you took out the withContext statement and just ran the block directly would any test fail? (If not, I think we should test that)
There was a problem hiding this comment.
Added test coverage for this, and testing also that we throw if its not a main thread dispatcher in the context.
There was a problem hiding this comment.
Whoops. Firebender had its own branch for the work we were doing and it did not get added.... stay tuned.
There was a problem hiding this comment.
Ok, added correctly now.
steve-the-edwards
force-pushed
the
sedwards/update-take-dispatcher-rules
branch
3 times, most recently
from
6badc8d to
7a813e0
Compare
steve-the-edwards
force-pushed
the
sedwards/update-take-dispatcher-rules
branch
from
7a813e0 to
0d757f2
Compare
No description provided.