Skip to content

Commit 0d99985

Browse files
committed
document the behavior around using zap.NewNop()
1 parent eeea6cd commit 0d99985

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

protocol/v2/qbft/controller/decided.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ func (c *Controller) UponDecided(msg *specqbft.ProcessingMessage) (*spectypes.Si
2424
isFutureDecided := msg.QBFTMessage.Height > c.Height
2525

2626
if inst == nil {
27+
// Since we are going to get rid of "decided" messages anyway, use zap.NewNop() here for simplicity.
2728
i := instance.NewInstance(zap.NewNop(), c.GetConfig(), c.CommitteeMember, c.Identifier, msg.QBFTMessage.Height, c.OperatorSigner)
2829
i.State.Round = msg.QBFTMessage.Round
2930
i.State.Decided = true

0 commit comments

Comments
 (0)