Skip to content

Audit uses of duplicate bucket iteration code #5048

@sisuresh

Description

@sisuresh

There are a couple parts of core that iterate over the bucket list that should be able to share code. We should audit core to find these uses. Here are a couple -

  1. getLiveBucketListBalanceForAsset from Add command line util to calculate total supply of assets and validate total coins for XLM. #4983 can use loadCompleteBucketListStateHelper, although this will load all of live state into memory. We could avoid this by changing the helper to loop over buckets from new->old instead of old->new.
  2. dumpStateArchivalStatistics

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanuprefactoring or other internal improvements

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions