Skip to content

Conversation

@KPR-V
Copy link

@KPR-V KPR-V commented Jul 2, 2025

Summary

This PR fixes issue #94 by making service messages (such as users joining, leaving, or group info changes) visible in the chat backup view. Previously, these events were backed up but not shown, resulting in incomplete chat histories.

Details

  • Removes the filter that previously hid service messages.
  • Renders service messages inline with chat history using a distinct, centered style.
  • Adds a formatServiceMessage helper to convert raw action data into readable text
  • Dynamically fetches user info for users referenced in service messages who are not already in the backup.
  • Gracefully handles cases where user info cannot be fetched, displaying "A user" as needed.
  • Skips rendering messages with unsupported media types.

Screenshots

Screenshot 2025-07-01 170103

Screenshot 2025-07-01 170111


Fixes #94

KPR-V added 2 commits July 1, 2025 16:55
Render service messages like user joins, leaves, and title changes in the backup dialog. This includes creating a helper to format action data into readable text and dynamically fetching details for unknown users. Fixes storacha#94
@Khwahish29
Copy link
Contributor

Hey @KPR-V great work! 🚀
I have reviewed the changes in the PR and it looks good to me @BravoNatalie

@KPR-V
Copy link
Author

KPR-V commented Jul 19, 2025

Hey @KPR-V great work! 🚀
I have reviewed the changes in the PR and it looks good to me @BravoNatalie

Thank you for the kind words and your time for reviewing my PR 😇 Greatly appreciate it

@jamiechicago312
Copy link

Flagging @travis or @BravoNatalie to review this PLDG PR for our TG mini app
Will post in Discord also

Copy link
Contributor

@BravoNatalie BravoNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work, especially for mapping out that huge list of service actions!

I’ve already left some comments, but here’s a quick summary of what I think could be adjusted in this PR:

  • Fix conflicts with main
  • Remove all uses of getEntity
  • For cases where we don’t know the participant’s username, handle them in a generic way. Just be mindful of the possibility of having multiple unknown users and account for plurals accordingly.

@KPR-V KPR-V closed this Jul 23, 2025
@KPR-V KPR-V force-pushed the fix/display-service-messages branch from 50e049f to a1411e6 Compare July 23, 2025 10:54
@KPR-V KPR-V reopened this Jul 23, 2025
@KPR-V
Copy link
Author

KPR-V commented Jul 23, 2025

hi @travis and @BravoNatalie

I have made the requested changes and have removed all the use cases of the getEntity

@KPR-V KPR-V requested review from BravoNatalie and travis July 23, 2025 17:36
@BravoNatalie BravoNatalie added the awaiting-review PR is ready for maintainer review. label Aug 12, 2025
@KPR-V
Copy link
Author

KPR-V commented Sep 8, 2025

Hi @travis, could you please take some time to review this PR? It would be greatly appreciated. 🙏👍😊
Also thank you @BravoNatalie for the approval😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is ready for maintainer review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Service Message Visualization

5 participants