-
Notifications
You must be signed in to change notification settings - Fork 18
fix(backup): display service messages in chat view #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Render service messages like user joins, leaves, and title changes in the backup dialog. This includes creating a helper to format action data into readable text and dynamically fetching details for unknown users. Fixes storacha#94
…ages and removing the unsupported media
|
Hey @KPR-V great work! 🚀 |
Thank you for the kind words and your time for reviewing my PR 😇 Greatly appreciate it |
|
Flagging @travis or @BravoNatalie to review this PLDG PR for our TG mini app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work, especially for mapping out that huge list of service actions!
I’ve already left some comments, but here’s a quick summary of what I think could be adjusted in this PR:
- Fix conflicts with
main - Remove all uses of
getEntity - For cases where we don’t know the participant’s username, handle them in a generic way. Just be mindful of the possibility of having multiple unknown users and account for plurals accordingly.
50e049f to
a1411e6
Compare
|
hi @travis and @BravoNatalie I have made the requested changes and have removed all the use cases of the |
|
Hi @travis, could you please take some time to review this PR? It would be greatly appreciated. 🙏👍😊 |
Summary
This PR fixes issue #94 by making service messages (such as users joining, leaving, or group info changes) visible in the chat backup view. Previously, these events were backed up but not shown, resulting in incomplete chat histories.
Details
formatServiceMessagehelper to convert raw action data into readable textScreenshots
Fixes #94