Skip to content

feat: add react native eslint config #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchalupa merged 4 commits into from
Nov 3, 2025
Merged

feat: add react native eslint config #272

pchalupa merged 4 commits into from
Nov 3, 2025

Conversation

@pchalupa
Copy link
Contributor

@pchalupa pchalupa commented Oct 20, 2025 •
edited
Loading

Adding a @strv/eslint-config-react-native based on the eslint-config-expo.

@pchalupa pchalupa self-assigned this Oct 20, 2025
@pchalupa pchalupa force-pushed the feat/react-native-eslint-config branch from a1e21d6 to 54d7643 Compare October 20, 2025 11:52
@pchalupa pchalupa marked this pull request as ready for review October 20, 2025 14:25
@pchalupa pchalupa requested review from a team October 20, 2025 14:26
matejpolak
matejpolak reviewed Oct 21, 2025
View reviewed changes
matejpolak
matejpolak approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@matejpolak matejpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 💪

@robertrossmann
Copy link
Member

robertrossmann commented Oct 21, 2025

Ideally this would extend at least @strv/eslint-config-base or even better, @strv/eslint-config-react as it's for React Native. 🤔

@pchalupa
Copy link
Contributor Author

pchalupa commented Oct 22, 2025 •
edited
Loading

Ideally this would extend at least @strv/eslint-config-base or even better, @strv/eslint-config-react as it's for React Native. 🤔

Good idea! Unfortunately, @strv/eslint-config-react is overly focused on the web. @strv/eslint-config-base enforces the style that we usually handle with prettier. But I added@strv/eslint-config-typescript. 🎉

@pchalupa pchalupa requested review from a team and matejpolak October 25, 2025 08:49
matejpolak
matejpolak reviewed Oct 27, 2025
View reviewed changes
@pchalupa pchalupa requested review from a team and matejpolak October 27, 2025 11:15
@pchalupa
feat: add react native eslint config
a7e4463 
chore: add license

chore: add package manager
@pchalupa pchalupa force-pushed the feat/react-native-eslint-config branch from 4810adc to 205f37b Compare November 3, 2025 14:18
@pchalupa
feat(eslint-config-react-native): add config
1331df0 
chore: rename package

fix: disable slow rules
@pchalupa pchalupa force-pushed the feat/react-native-eslint-config branch 3 times, most recently from 9333873 to 671a9e3 Compare November 3, 2025 14:26
@pchalupa pchalupa force-pushed the feat/react-native-eslint-config branch from 671a9e3 to e06cfba Compare November 3, 2025 14:27
@pchalupa
feat(eslint-config-react-native): define rules
64379c0 
fix: add ignore

chore: add ts plugin and parser

fix: update files

chore: bump version

docs: update docs

chore: deps align

feat: extend by typescript config

fix: use singlequote

fix: format

docs: add links to rules
@pchalupa pchalupa force-pushed the feat/react-native-eslint-config branch from e06cfba to 64379c0 Compare November 3, 2025 14:30
@pchalupa pchalupa merged commit eb76dba into master Nov 3, 2025
3 checks passed
@pchalupa pchalupa deleted the feat/react-native-eslint-config branch November 3, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejpolak matejpolak matejpolak approved these changes

@robertrossmann robertrossmann Awaiting requested review from robertrossmann robertrossmann is a code owner

Assignees

@pchalupa pchalupa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pchalupa @robertrossmann @matejpolak