Skip to content

Conversation

@zGerden
Copy link
Contributor

@zGerden zGerden commented Mar 14, 2015

Title says it all :)

@surjithctly
Copy link
Owner

Hey Zan, Thanks for putting this together, Did you test it?

Anyway, I will also do a quick round of testing and will merge tomorrow...

@zGerden
Copy link
Contributor Author

zGerden commented Mar 15, 2015

Hello,
Yes I tested it, but it wouldn't be bad if currency rate caching would been tested for a little longer. Also, when you merge, please don't create new version, as I have to fix one issue before.

@surjithctly
Copy link
Owner

surjithctly commented Mar 15, 2015 via email

@zGerden
Copy link
Contributor Author

zGerden commented Mar 16, 2015

OK, I fixed it.

@zGerden
Copy link
Contributor Author

zGerden commented Mar 23, 2015

Hello, I tested it for few days and noticed only that settings weren't saved, but it all works now.

@surjithctly
Copy link
Owner

Great.. I've been busy these weeks, Will push an update soon.

@surjithctly
Copy link
Owner

One more thing I found that, The conversion from localstorage to storage api is too slow and stopping when I clicked options page. So, Few of the localstorage items stays there and some in the storage API. I need to click reload quite few times to make it convert fully.

Do you have any idea why this is happening?

@surjithctly
Copy link
Owner

@zan-gerden got my message?

@zGerden
Copy link
Contributor Author

zGerden commented Mar 26, 2015

Yes I did, but currently I don't have much time and will fix this maybe next week.

@surjithctly
Copy link
Owner

surjithctly commented Mar 26, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants