minor #72 chore: remove occurrences of empty() (alexandre-daubois, chr-hertel)

This PR was merged into the main branch.

Discussion
----------

chore: remove occurrences of `empty()`

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  |no
| Docs?         | no
| Issues        |
| License       | MIT

Cherry picking php-llm/llm-chain#374

Commits
-------

c0d688f chore: use [] checks instead of count with zero on array
fb3d1a8 chore: use isset instead of bool cast on $_ENV
14c448c chore: remove occurrences of `empty()` (#374)

Author: chr-hertel

src/Bridge/Anthropic/Contract/AssistantMessageNormalizer.php

@@ -58,7 +58,7 @@ public function normalize(mixed $data, ?string $format = null, array $context =
                     'type' => 'tool_use',
                     'id' => $toolCall->id,
                     'name' => $toolCall->name,
-                    'input' => empty($toolCall->arguments) ? new \stdClass() : $toolCall->arguments,
+                    'input' => [] !== $toolCall->arguments ? $toolCall->arguments : new \stdClass(),
                 ];
             }, $data->toolCalls),
         ];

src/Bridge/Anthropic/ResponseConverter.php

@@ -42,7 +42,7 @@ public function convert(ResponseInterface $response, array $options = []): LlmRe
 
         $data = $response->toArray();
 
-        if (!isset($data['content']) || 0 === \count($data['content'])) {
+        if (!isset($data['content']) || [] === $data['content']) {
             throw new RuntimeException('Response does not contain any content');
         }
 
@@ -53,11 +53,11 @@ public function convert(ResponseInterface $response, array $options = []): LlmRe
             }
         }
 
-        if (!isset($data['content'][0]['text']) && 0 === \count($toolCalls)) {
+        if (!isset($data['content'][0]['text']) && [] === $toolCalls) {
             throw new RuntimeException('Response content does not contain any text nor tool calls.');
         }
 
-        if (!empty($toolCalls)) {
+        if ([] !== $toolCalls) {
             return new ToolCallResponse(...$toolCalls);
         }
 

src/Bridge/Bedrock/Anthropic/ClaudeHandler.php

@@ -63,7 +63,7 @@ public function convert(InvokeModelResponse $bedrockResponse): ToolCallResponse|
     {
         $data = json_decode($bedrockResponse->getBody(), true, 512, \JSON_THROW_ON_ERROR);
 
-        if (!isset($data['content']) || 0 === \count($data['content'])) {
+        if (!isset($data['content']) || [] === $data['content']) {
             throw new RuntimeException('Response does not contain any content');
         }
 
@@ -77,7 +77,7 @@ public function convert(InvokeModelResponse $bedrockResponse): ToolCallResponse|
                 $toolCalls[] = new ToolCall($content['id'], $content['name'], $content['input']);
             }
         }
-        if (!empty($toolCalls)) {
+        if ([] !== $toolCalls) {
             return new ToolCallResponse(...$toolCalls);
         }
 

src/Bridge/Bedrock/Nova/Contract/AssistantMessageNormalizer.php

@@ -57,7 +57,7 @@ public function normalize(mixed $data, ?string $format = null, array $context =
                         'toolUse' => [
                             'toolUseId' => $toolCall->id,
                             'name' => $toolCall->name,
-                            'input' => empty($toolCall->arguments) ? new \stdClass() : $toolCall->arguments,
+                            'input' => [] !== $toolCall->arguments ? $toolCall->arguments : new \stdClass(),
                         ],
                     ];
                 }, $data->toolCalls),

src/Bridge/Bedrock/Nova/NovaHandler.php

@@ -64,7 +64,7 @@ public function convert(InvokeModelResponse $bedrockResponse): ToolCallResponse|
     {
         $data = json_decode($bedrockResponse->getBody(), true, 512, \JSON_THROW_ON_ERROR);
 
-        if (!isset($data['output']) || 0 === \count($data['output'])) {
+        if (!isset($data['output']) || [] === $data['output']) {
             throw new RuntimeException('Response does not contain any content');
         }
 
@@ -78,7 +78,7 @@ public function convert(InvokeModelResponse $bedrockResponse): ToolCallResponse|
                 $toolCalls[] = new ToolCall($content['toolUse']['toolUseId'], $content['toolUse']['name'], $content['toolUse']['input']);
             }
         }
-        if (!empty($toolCalls)) {
+        if ([] !== $toolCalls) {
             return new ToolCallResponse(...$toolCalls);
         }
 

src/Bridge/HuggingFace/ModelClient.php

@@ -77,7 +77,7 @@ private function getPayload(array|string $payload, array $options): array
         if (\is_string($payload) || !(isset($payload['body']) || isset($payload['json']))) {
             $payload = ['json' => ['inputs' => $payload]];
 
-            if (0 !== \count($options)) {
+            if ([] !== $options) {
                 $payload['json']['parameters'] = $options;
             }
         }

src/Contract/JsonSchema/Factory.php

@@ -90,7 +90,7 @@ public function buildProperties(string $className): ?array
      */
     private function convertTypes(array $elements): ?array
     {
-        if (0 === \count($elements)) {
+        if ([] === $elements) {
             return null;
         }
 

src/Message/AssistantMessage.php

@@ -43,6 +43,6 @@ public function getId(): Uuid
 
     public function hasToolCalls(): bool
     {
-        return null !== $this->toolCalls && 0 !== \count($this->toolCalls);
+        return null !== $this->toolCalls && [] !== $this->toolCalls;
     }
 }

src/Response/Choice.php

@@ -45,6 +45,6 @@ public function getToolCalls(): array
 
     public function hasToolCall(): bool
     {
-        return 0 !== \count($this->toolCalls);
+        return [] !== $this->toolCalls;
     }
 }

src/Response/ChoiceResponse.php

@@ -25,7 +25,7 @@ final class ChoiceResponse extends BaseResponse
 
     public function __construct(Choice ...$choices)
     {
-        if (0 === \count($choices)) {
+        if ([] === $choices) {
             throw new InvalidArgumentException('Response must have at least one choice.');
         }