Merge branch '4.3' into 4.4

* 4.3:
  [Mailer] Remove line breaks in email attachment content
  Update links to documentation
  [Validator] Add the missing translations for the Arabic (ar) locale
  ensure to expect no validation for the right reasons
  [PhpUnitBridge] Add test case for @expectedDeprecation annotation
  [PhpUnitBridge][SymfonyTestsListenerTrait] Remove $testsWithWarnings stack
  [Mailer][MailchimpBridge] Fix missing attachments when sending via Mandrill API
  [Mailer][MailchimpBridge] Fix incorrect sender address when sender has name
  [HttpClient] fix capturing SSL certificates with NativeHttpClient
  [TwigBridge][Form] Added missing help messages in form themes
  Update year in license files
  Update year in license files
  [HttpClient] fix typo
  [Console][FormatterHelper] Use helper strlen statically and remove duplicated code
  [Routing] Fix i18n routing when the url contains the locale
  Fix BC issue in phpDoc Reflection library
  [Translator] Performance improvement in MessageCatalogue and catalogue operations.

Author: nicolas-grekas

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2019 Fabien Potencier
+Copyright (c) 2004-2020 Fabien Potencier
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -6,7 +6,7 @@ The Form component allows you to easily create, process and reuse HTML forms.
 Resources
 ---------
 
-  * [Documentation](https://symfony.com/doc/current/components/form/index.html)
+  * [Documentation](https://symfony.com/doc/current/components/form.html)
   * [Contributing](https://symfony.com/doc/current/contributing/index.html)
   * [Report issues](https://github.com/symfony/symfony/issues) and
     [send Pull Requests](https://github.com/symfony/symfony/pulls)

Tests/Extension/Validator/Constraints/FormValidatorTest.php

@@ -135,7 +135,10 @@ public function testDontValidateIfParentWithoutValidConstraint()
         $parent->add($form);
 
         $form->setData($object);
+        $parent->submit([]);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -190,10 +193,15 @@ public function testDontValidateIfNoValidationGroups()
                 'validation_groups' => [],
             ])
             ->setData($object)
+            ->setCompound(true)
+            ->setDataMapper(new PropertyPathMapper())
             ->getForm();
 
         $form->setData($object);
+        $form->submit([]);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -216,6 +224,8 @@ public function testDontValidateConstraintsIfNoValidationGroups()
         // Launch transformer
         $form->submit('foo');
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -238,6 +248,8 @@ public function testDontValidateChildConstraintsIfCallableNoValidationGroups()
         $form->add($child);
         $form->submit([]);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -266,6 +278,8 @@ function () { throw new TransformationFailedException(); }
         // Launch transformer
         $form->submit('foo');
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertFalse($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -301,6 +315,8 @@ function () { throw new TransformationFailedException(); }
         // Launch transformer
         $form->submit('foo');
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertFalse($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -412,6 +428,8 @@ function () { throw new TransformationFailedException(); }
         // Launch transformer
         $form->submit(['child' => 'foo']);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertFalse($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -617,7 +635,10 @@ public function testDontWalkScalars()
         $form = $this->getBuilder()
             ->setData('scalar')
             ->getForm();
+        $form->submit('foo');
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -635,6 +656,8 @@ public function testViolationIfExtraData()
 
         $form->submit(['foo' => 'bar']);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());
@@ -656,6 +679,8 @@ public function testViolationFormatIfMultipleExtraFields()
 
         $form->submit(['foo' => 'bar', 'baz' => 'qux', 'quux' => 'quuz']);
 
+        $this->assertTrue($form->isSubmitted());
+        $this->assertTrue($form->isSynchronized());
         $this->expectNoValidate();
 
         $this->validator->validate($form, new Form());