bug #62182 [VarDumper] Fix dumping CurlHttpClient instances (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 41fd6c4ae28c · 2025-10-27T21:36:44.000+01:00
This PR was merged into the 7.4 branch.

Discussion
----------

[VarDumper] Fix dumping CurlHttpClient instances

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

Too niche for a test case 🙏 😬

Commits
-------

d8f05d45d45 [VarDumper] Fix dumping CurlHttpClient instances
diff --git a/Caster/SymfonyCaster.php b/Caster/SymfonyCaster.php
@@ -51,7 +51,7 @@ public static function castRequest(Request $request, array $a, Stub $stub, bool
     public static function castHttpClient($client, array $a, Stub $stub, bool $isNested): array
     {
         $multiKey = \sprintf("\0%s\0multi", $client::class);
-        if (isset($a[$multiKey])) {
+        if (isset($a[$multiKey]) && !$a[$multiKey] instanceof Stub) {
             $a[$multiKey] = new CutStub($a[$multiKey]);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public static function castRequest(Request $request, array $a, Stub $stub, bool`
`51`	`51`	`public static function castHttpClient($client, array $a, Stub $stub, bool $isNested): array`
`52`	`52`	`{`
`53`	`53`	`$multiKey = \sprintf("\0%s\0multi", $client::class);`
`54`		`- if (isset($a[$multiKey])) {`
	`54`	`+ if (isset($a[$multiKey]) && !$a[$multiKey] instanceof Stub) {`
`55`	`55`	`$a[$multiKey] = new CutStub($a[$multiKey]);`
`56`	`56`	`}`
`57`	`57`