Skip to content

Commit 0373e78

Browse files
committed
Merge branch 'dev' of github.com:strongoier/taichi into dev
2 parents 9b23c6b + af26624 commit 0373e78

File tree

5 files changed

+20
-14
lines changed

5 files changed

+20
-14
lines changed

taichi/codegen/codegen_llvm.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,13 +1676,14 @@ void CodeGenLLVM::create_offload_struct_for(OffloadedStmt *stmt, bool spmd) {
16761676
if (!prog->config.packed) {
16771677
for (int i = 0; i < snode->num_active_indices; i++) {
16781678
auto j = snode->physical_index_position[i];
1679-
if (!bit::is_power_of_two(snode->extractors[j].num_elements_from_root)) {
1679+
if (!bit::is_power_of_two(
1680+
snode->extractors[j].num_elements_from_root)) {
16801681
auto coord = coord_object.get("val", tlctx->get_constant(j));
16811682
exec_cond = builder->CreateAnd(
1682-
exec_cond,
1683-
builder->CreateICmp(
1684-
llvm::CmpInst::ICMP_SLT, coord,
1685-
tlctx->get_constant(snode->extractors[j].num_elements_from_root)));
1683+
exec_cond, builder->CreateICmp(
1684+
llvm::CmpInst::ICMP_SLT, coord,
1685+
tlctx->get_constant(
1686+
snode->extractors[j].num_elements_from_root)));
16861687
}
16871688
}
16881689
}

taichi/struct/struct.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ void infer_snode_properties(SNode &snode, bool packed) {
1414
auto &ch = snode.ch[ch_id];
1515
ch->parent = &snode;
1616
for (int i = 0; i < taichi_max_num_indices; i++) {
17-
ch->extractors[i].num_elements_from_root *= snode.extractors[i].num_elements_from_root;
17+
ch->extractors[i].num_elements_from_root *=
18+
snode.extractors[i].num_elements_from_root;
1819
bool found = false;
1920
for (int k = 0; k < taichi_max_num_indices; k++) {
2021
if (snode.physical_index_position[k] == i) {

taichi/transforms/lower_access.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@ class LowerAccess : public IRVisitor {
4949
bool packed;
5050

5151
LowerAccess(const std::vector<SNode *> &kernel_forces_no_activate,
52-
bool lower_atomic_ptr, bool packed)
52+
bool lower_atomic_ptr,
53+
bool packed)
5354
: kernel_forces_no_activate(kernel_forces_no_activate),
54-
lower_atomic_ptr(lower_atomic_ptr), packed(packed) {
55+
lower_atomic_ptr(lower_atomic_ptr),
56+
packed(packed) {
5557
// TODO: change this to false
5658
allow_undefined_visitor = true;
5759
current_struct_for = nullptr;
@@ -100,8 +102,8 @@ class LowerAccess : public IRVisitor {
100102
TI_ASSERT(!pointer_needs_activation);
101103
}
102104

103-
PtrLowererImpl lowerer{leaf_snode, indices, snode_op, is_bit_vectorized,
104-
lowered, packed};
105+
PtrLowererImpl lowerer{leaf_snode, indices, snode_op,
106+
is_bit_vectorized, lowered, packed};
105107
lowerer.set_pointer_needs_activation(pointer_needs_activation);
106108
lowerer.set_lower_access(this);
107109
lowerer.run();
@@ -305,8 +307,8 @@ namespace irpass {
305307
bool lower_access(IRNode *root,
306308
const CompileConfig &config,
307309
const LowerAccessPass::Args &args) {
308-
bool modified =
309-
LowerAccess::run(root, args.kernel_forces_no_activate, args.lower_atomic, config.packed);
310+
bool modified = LowerAccess::run(root, args.kernel_forces_no_activate,
311+
args.lower_atomic, config.packed);
310312
type_check(root, config);
311313
return modified;
312314
}

tests/cpp/transforms/scalar_pointer_lowerer_test.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,9 @@ TEST_F(ScalarPointerLowererTest, Basic) {
6262
LowererImpl lowerer{leaf_snode_,
6363
std::vector<Stmt *>{builder.get_int32(loop_index)},
6464
SNodeOpType::undefined,
65-
/*is_bit_vectorized=*/false, &lowered, /*packed=*/false};
65+
/*is_bit_vectorized=*/false,
66+
&lowered,
67+
/*packed=*/false};
6668
lowerer.run();
6769
// There are three linearized stmts:
6870
// 0: for root

tests/python/test_packed_size.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
def test_packed_size():
66
x = ti.field(ti.i32)
77
ti.root.dense(ti.i, 20).dense(ti.ijk, 334).place(x)
8-
assert x.snode.parent().parent().cell_size_bytes == 4 * 334 ** 3
8+
assert x.snode.parent().parent().cell_size_bytes == 4 * 334**3

0 commit comments

Comments
 (0)