Fix padding unconditionally added to top-level submenus for icons even when there's no icon on Linux #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r icons, even when there wasn't any icon
|
thank you for the pr! would you mind adding a small changefile like https://raw.githubusercontent.com/tauri-apps/muda/0ae81ad8b22dd2622e302254ce434d14880087a3/.changes/refactor-simplify-internal-id-usage.md ? :) |
|
@FabianLars Added the changefile and fixed the CI on this PR and #322 as well. |
amrbashir
requested changes
Oct 17, 2025
amrbashir
requested changes
Oct 21, 2025
amrbashir
approved these changes
Nov 1, 2025
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
mudaautomatically reserves space for icons in top-level submenus; however, because of a bug that I've fixed in this PR, this was being done for all submenus, even if they didn't have icons. See the screenshots below.Screenshots