Use insert in Options

[wouterpeere]

Hi @tblanke

Currently, the floatbox and intbox have a certain amount of characters. This makes it sometimes really enjoying to change certain values.

E.g. Image you have a floatbox with the value '0,0900' and you want to change it to '0,950'. You cannot just type a 5 behind the 9, since then we would have '0,09500' which is more than 5 characters. So you first have to go to '0,90' before you can type the 5. This is really annoying behaviour in my opinion ...

Best regards
Wouter Peere

[wouterpeere]

I implemented a first idea.
Now, if you have a float_box with 2 decimal numbers, and you insert a number between the first and the second decimal number, this works and the last number is removed.
However, when clicking away, this is defaulted to 0.00, which is not wanted.

Do you like this approach? Maybe we can figure it out in this way ...

Best,
@wouterpeere

[tblanke]

I think I have found a solution. Can you please take a look?

[wouterpeere]

Hi @tblanke

This really looks nice!

Although, I think it would be even better if the insert also works with the numbers before the decimal separator. Looking at the example now, the floatbox b has a default value of "100,0000". I can start typing after the comma and insert numbers over there, but I would also like to be able to type at position 2 a 5 and get "150,0000".

I think this would require some more tweaking, but perhaps this alone is already good to go in v0.3.0?

Best,
@wouterpeere

[tblanke]

Hi @wouterpeere,

I have implemented the discussed approach. Can you please have a look?

Kind regards
@tblanke

[wouterpeere]

Hi @tblanke

Looks great!

I however found a small bug.

1. Set the value of float_b to 12.222,22
2. Insert the cursor after the '1' and start typing 0's to get to the max of '100.000'.
3. The cursor stops at 10.000,22 so a) it does not go to the decimal places here

Best
@wouterpeere

[tblanke]

Hi @wouterpeere ,

I have fixed it.

with best regards
@tblanke

[wouterpeere]

Hi @tblanke

Not quite correct, I think.

1. Start with 12.000,00
2. Set cursor after 1 and type 0's
3. You end up with 10.000,00 instead of 100.000,00

Now, notice that if you click away and back between two 0's, you get to 100.000 anyways.

[tblanke]

Hi @wouterpeere,

This is the correct behaviour. If you end up at 10.000,20 and type 10.000,020, you are below the limit and the think cached is the bejond decimal sign behaviour. So If you start typing 0's after the 1 and the number is 10.000,20, you will reach 100.000,00.
So the main point I wanted to make is while typing in your case you are at some point below the maximal value (10.000,20).

[wouterpeere]

Hi @tblanke

Oké, I can see that!

There are some other problems with the negative values:

1. Start with -10.000,00
2. Insert a '0' after the '1' and you end up with "-.100.000,00"

[tblanke]

Hi @wouterpeere ,

Correct that is a bug. Which is fixed now.

[wouterpeere]

Hi @tblanke

Oke, I think I have a couple of small bugs left:
If you have '-100.000,00' you can type as many zeros as you want between the - and the 1. Strictly speaking, that is not wrong, but just annoying. These zeros are however deleted when you click away.

1. Now, start with '-100.000,00' and type four zeros before the 1. When you arrive at the fourth zero, the position of the cursor is changed '-0.00I0.100.000,00'. So the cursor jumps away from the 1
2. If you start with '-10.000,00' and you type '0.010.000,00', set the cursor here: '0.0I10.000,00'. If you remove the zero, pressing backspace, you end up with '01I0.000,00', so also here the cursor jumps ...

[tblanke]

Hi @wouterpeere ,

I have fixed it.