Optimize ScriptSplitter from O(n*m) to O(1) when initializing database (#11130)

hspragg-godaddy · web-flow · commit 57e03d0a2ed7 · 2025-10-30T16:54:17.000-06:00
diff --git a/modules/database-commons/src/main/java/org/testcontainers/ext/ScriptSplitter.java b/modules/database-commons/src/main/java/org/testcontainers/ext/ScriptSplitter.java
@@ -36,7 +36,7 @@ void split() {
                     //skip
                     break;
                 case WHITESPACE:
-                    if (!sb.toString().endsWith(" ")) {
+                    if (sb.length() == 0 || sb.charAt(sb.length() - 1) != ' ') {
                         sb.append(' ');
                     }
                     break;

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ void split() {`
`36`	`36`	`//skip`
`37`	`37`	`break;`
`38`	`38`	`case WHITESPACE:`
`39`		`- if (!sb.toString().endsWith(" ")) {`
	`39`	`+ if (sb.length() == 0 \|\| sb.charAt(sb.length() - 1) != ' ') {`
`40`	`40`	`sb.append(' ');`
`41`	`41`	`}`
`42`	`42`	`break;`