Merge pull request #69 from jelmer/ruff-check

Run ruff check

Author: jelmer

.github/workflows/test.yml

@@ -43,6 +43,10 @@ jobs:
         run: |
           python -W once -m testtools.run testrepository.tests.test_suite
 
+      - name: Lint
+        run: |
+          ruff check .
+
       - name: Check formatting
         run: |
           ruff format --check .

testrepository/__init__.py

@@ -22,6 +22,9 @@
 The tests package contains tests and test specific support code.
 """
 
+__all__ = ["__version__"]
+
+
 try:
     # If setuptools_scm is installed (e.g. in a development environment with
     # an editable install), then use it to determine the version dynamically.

testrepository/arguments/__init__.py

@@ -70,7 +70,7 @@ def summary(self):
             return result + "+"
         if minmax == (0, None):
             return result + "*"
-        if minmax[1] == None:
+        if minmax[1] is None:
             minmax = (minmax[0], "")
         return result + "{%s,%s}" % minmax
 

testrepository/commands/__init__.py

@@ -37,8 +37,6 @@
 import os
 import sys
 
-import subunit
-
 from testrepository.repository import file
 
 

testrepository/commands/failing.py

@@ -17,7 +17,6 @@
 import optparse
 
 import testtools
-from testtools import ExtendedToStreamDecorator, MultiTestResult
 
 from testrepository.commands import Command
 from testrepository.testcommand import TestCommand

testrepository/commands/last.py

@@ -16,7 +16,6 @@
 
 import optparse
 
-import testtools
 
 from testrepository.commands import Command
 from testrepository.testcommand import TestCommand

testrepository/commands/list_tests.py

@@ -16,7 +16,6 @@
 
 from io import BytesIO
 
-from testtools import TestResult
 
 from testrepository.arguments.doubledash import DoubledashArgument
 from testrepository.arguments.string import StringArgument

testrepository/commands/load.py

@@ -15,7 +15,6 @@
 """Load data into a repository."""
 
 from functools import partial
-from operator import methodcaller
 import optparse
 import threading
 
@@ -111,9 +110,9 @@ def run(self):
             streams = map(opener, self.ui.arguments["streams"])
         else:
             streams = self.ui.iter_streams("subunit")
-        mktagger = lambda pos, result: testtools.StreamTagger(
-            [result], add=["worker-%d" % pos]
-        )
+
+        def mktagger(pos, result):
+            return testtools.StreamTagger([result], add=["worker-%d" % pos])
 
         def make_tests():
             for pos, stream in enumerate(streams):

testrepository/commands/run.py

@@ -17,13 +17,9 @@
 from io import BytesIO
 from math import ceil
 import optparse
-import re
 
 import subunit
 import testtools
-from testtools import (
-    TestByTestResult,
-)
 
 from testrepository.arguments.doubledash import DoubledashArgument
 from testrepository.arguments.string import StringArgument

testrepository/repository/__init__.py

@@ -27,7 +27,7 @@
 the initialize function in the appropriate repository module.
 """
 
-from testtools import StreamToDict, TestResult
+from testtools import StreamToDict
 
 
 class AbstractRepositoryFactory(object):