The check for a file's existence within the worktree in add function is useless.

In the `add()` function, a file's existence within the worktree is checked.

https://github.com/thblt/write-yourself-a-git/blob/7d011742b2f428acbfaeebb6ba495630808d7437/write-yourself-a-git.org?plain=1#L3280-L3281

However, this check is redundant because it has already been performed in the rm() function.

https://github.com/thblt/write-yourself-a-git/blob/7d011742b2f428acbfaeebb6ba495630808d7437/write-yourself-a-git.org?plain=1#L3186-L3199


	def rm(repo, paths, delete=True, skip_missing=False):
	# Find and read the index
	index = index_read(repo)

	worktree = repo.worktree + os.sep

	# Make paths absolute
	abspaths = set()
	for path in paths:
	abspath = os.path.abspath(path)
	if abspath.startswith(worktree):
	abspaths.add(abspath)
	else:
	raise Exception(f"Cannot remove paths outside of worktree: {paths}")

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

The check for a file's existence within the worktree in add function is useless. #53

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if not (abspath.startswith(worktree) and os.path.isfile(abspath)):
	raise Exception(f"Not a file, or outside the worktree: {paths}")

The check for a file's existence within the worktree in add function is useless. #53

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions