Skip to content

Fully consistent 16 byte long nonce #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fully consistent 16 byte long nonce #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TheengsGateway/decryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ class VictronDecryptor(AdvertisementDecryptor):

def compute_nonce(self, address: str, decoded_json: dict) -> bytes:
"""Get the nonce from a specific address and JSON input."""
# The nonce is provided in the message and needs to be padded to 8 bytes
# The nonce is provided in the message and needs to be padded to 16 bytes
nonce = bytes.fromhex(decoded_json["ctr"])
nonce = nonce.ljust(8, b"\x00") # Pad to 8 bytes with zeros
nonce = nonce.ljust(16, b"\x00") # Pad to 16 bytes with zeros
return nonce

def decrypt(
Expand Down