Skip to content

Commit 09b2b24

Browse files
authored
Do not show datasources which have spotter disabled (#70)
1 parent 19588f2 commit 09b2b24

File tree

3 files changed

+35
-5
lines changed

3 files changed

+35
-5
lines changed

src/thoughtspot/thoughtspot-service.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,9 @@ export class ThoughtSpotService {
358358
});
359359

360360
const results = resp
361-
.filter(d => d.metadata_header.type === "WORKSHEET" || d.metadata_header.subType === "WORKSHEET")
361+
// Tables can also be used for spotter now
362+
//.filter(d => d.metadata_header.type === "WORKSHEET" || d.metadata_header.subType === "WORKSHEET")
363+
.filter(d => d.metadata_header.aiAnswerGenerationDisabled === false)
362364
.map(d => ({
363365
name: d.metadata_header.name,
364366
id: d.metadata_header.id,

test/servers/mcp-server.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ describe("MCP Server", () => {
5050
name: "Sales Data",
5151
description: "Sales data for the current year",
5252
type: "WORKSHEET",
53+
aiAnswerGenerationDisabled: false,
5354
},
5455
},
5556
{
@@ -58,6 +59,7 @@ describe("MCP Server", () => {
5859
name: "Customer Data",
5960
description: "Customer information and demographics",
6061
type: "WORKSHEET",
62+
aiAnswerGenerationDisabled: false,
6163
},
6264
},
6365
]),

test/thoughtspot/thoughtspot-service.spec.ts

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -510,23 +510,44 @@ describe('thoughtspot-service', () => {
510510
type: 'WORKSHEET',
511511
name: 'Sales Data',
512512
id: 'ws1',
513-
description: 'Sales information'
513+
description: 'Sales information',
514+
aiAnswerGenerationDisabled: false
514515
}
515516
},
516517
{
517518
metadata_header: {
518519
type: 'WORKSHEET',
519520
name: 'Revenue Data',
520521
id: 'ws2',
521-
description: 'Revenue information'
522+
description: 'Revenue information',
523+
aiAnswerGenerationDisabled: false
522524
}
523525
},
524526
{
525527
metadata_header: {
526-
type: 'LOGICAL_TABLE', // This should be filtered out
528+
type: 'WORKSHEET',
529+
name: 'Revenue Data aiAnswerGenerationDisabled',
530+
id: 'ws3',
531+
description: 'Revenue information',
532+
aiAnswerGenerationDisabled: true
533+
}
534+
},
535+
{
536+
metadata_header: {
537+
type: 'LOGICAL_TABLE', // This should be filtered out due to aiAnswerGenerationDisabled: true
527538
name: 'Other Data',
528539
id: 'lt1',
529-
description: 'Other information'
540+
description: 'Other information',
541+
aiAnswerGenerationDisabled: true
542+
}
543+
},
544+
{
545+
metadata_header: {
546+
type: 'LOGICAL_TABLE', // This should be filtered out due to aiAnswerGenerationDisabled: true
547+
name: 'Other Data 2',
548+
id: 'lt2',
549+
description: 'Other information',
550+
aiAnswerGenerationDisabled: false
530551
}
531552
}
532553
];
@@ -554,6 +575,11 @@ describe('thoughtspot-service', () => {
554575
name: 'Revenue Data',
555576
id: 'ws2',
556577
description: 'Revenue information'
578+
},
579+
{
580+
name: 'Other Data 2',
581+
id: 'lt2',
582+
description: 'Other information'
557583
}
558584
]);
559585
});

0 commit comments

Comments
 (0)