Handle dot-prefixed names in custom translation (#1530)

---------

Co-authored-by: Hadley Wickham <[email protected]>

Author: MichaelChirico

NEWS.md

@@ -1,5 +1,6 @@
 # dbplyr (development version)
 
+* Custom translations of functions starting with `.` work (@MichaelChirico, #1529).
 * SQL Server 2025 (version 17.0) now supports stringr regex functions: `str_detect()`, `str_starts()`, `str_ends()`, `str_replace()`, `str_replace_all()`, `str_remove()`, `str_remove_all()`, `str_extract()`, and `str_count()`. Fixed pattern versions of `str_detect()`, `str_starts()`, and `str_ends()` work on all SQL Server versions (#1671).
 * MS Access now correctly generates SQL for multiple joins by adding required parentheses (#1576).
 * `.data$col`, `.data[[col]]`, `.env$var`, and `.env$[[var]]` now work correctly inside `across()` (#1520).

R/tidyeval.R

@@ -290,7 +290,7 @@ find_fun <- function(fun) {
 fun_name <- function(fun) {
   # `dtplyr` uses the same idea but needs different environments
   pkg_env <- env_parent(global_env())
-  known <- c(ls(base_agg), ls(base_scalar))
+  known <- c(env_names(base_agg), env_names(base_scalar))
 
   for (x in known) {
     if (!env_has(pkg_env, x, inherit = TRUE)) {

R/translate-sql-helpers.R

@@ -64,18 +64,18 @@ sql_variant <- function(
   check_environment(window)
 
   # Need to check that every function in aggregate also occurs in window
-  missing <- setdiff(ls(aggregate), ls(window))
+  missing <- setdiff(env_names(aggregate), env_names(window))
   if (length(missing) > 0) {
     warn(paste0(
       "Translator is missing window variants of the following aggregate functions:\n",
       paste0("* ", missing, "\n", collapse = "")
     ))
   }
 
-  aggregate_fns <- ls(envir = aggregate)
+  aggregate_fns <- env_names(aggregate)
 
   # An ensure that every window function is flagged in aggregate context
-  missing <- setdiff(ls(window), ls(aggregate))
+  missing <- setdiff(env_names(window), env_names(aggregate))
   missing_funs <- lapply(missing, sql_aggregate_win)
   env_bind(aggregate, !!!set_names(missing_funs, missing))
 
@@ -95,7 +95,7 @@ is.sql_variant <- function(x) inherits(x, "sql_variant")
 #' @export
 print.sql_variant <- function(x, ...) {
   wrap_ls <- function(x, ...) {
-    vars <- sort(ls(envir = x))
+    vars <- sort(env_names(x))
     wrapped <- strwrap(paste0(vars, collapse = ", "), ...)
     if (identical(wrapped, "")) {
       return()
@@ -120,7 +120,7 @@ print.sql_variant <- function(x, ...) {
 
 #' @export
 names.sql_variant <- function(x) {
-  c(ls(envir = x$scalar), ls(envir = x$aggregate), ls(envir = x$window))
+  c(env_names(x$scalar), env_names(x$aggregate), env_names(x$window))
 }
 
 #' @export

R/translate-sql-window.R

@@ -403,7 +403,7 @@ uses_window_fun <- function(x, con, lq) {
   check_list(x)
 
   calls <- unlist(lapply(x, all_calls))
-  win_f <- ls(envir = dbplyr_sql_translation(con)$window)
+  win_f <- env_names(dbplyr_sql_translation(con)$window)
   any(calls %in% win_f)
 }
 
@@ -430,7 +430,7 @@ is_aggregating <- function(x, non_group_cols, agg_f) {
 }
 
 common_window_funs <- function() {
-  ls(dbplyr_sql_translation(NULL)$window) # nocov
+  env_names(dbplyr_sql_translation(NULL)$window) # nocov
 }
 
 #' @noRd

R/verb-filter.R

@@ -84,7 +84,7 @@ add_filter <- function(.data, dots) {
     # Do partial evaluation, then extract out window functions
     where <- translate_window_where_all(
       dots,
-      ls(dbplyr_sql_translation(con)$window)
+      env_names(dbplyr_sql_translation(con)$window)
     )
 
     # Add extracted window expressions as columns