Skip to content

Update pprof to work with Criterion 0.6 #274

@GeeWee

Description

@GeeWee

The given example in the readme

use pprof::criterion::{PProfProfiler, Output};

criterion_group!{
    name = benches;
    config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
    targets = bench
}
criterion_main!(benches);

Does not work with Criterion 0.6, as the Profiler trait is implemented for Criterion 0.5.1 (which is the dependency), and not for 0.6.

Seems like there are several PRs like #271 to fix this, so I am mostly creating this issue in support of them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions