Replies: 3 comments 8 replies
-
|
Hi, |
Beta Was this translation helpful? Give feedback.
-
|
Hi @riesi77
Addon also exists for Till's work, check my repo |
Beta Was this translation helpful? Give feedback.
-
|
Thanks. You can reach me direct under carconnectivity at fischernet. net
17 Oct 2025 18:59:48 Till Steinbach ***@***.***>:
…
Hi Till, I got some additional endpoints for Skoda already, mainly vehicle config data though. Still trying to find out the right endpoint URLs for more. Found some timers for climatization as well. Would you share more ?
Can I send you a direct message somewhere?
General Question on PR's: Do you prefer multiple smaller ones which might be easier to review and integrate? Or rather one bigger one with multiple significant features?
smaller ones would make the process a bit quicker, that would allow to merge things while discussion about others can continue. But in general everything is fine.
Also some new datapoints might be beneficial to the framework and not only Skoda (or Audi) specific. What would be your preference there? PR for both, or keep them in the Connector and then decide later?
Yes, often support in the main framework is the right way to go. My idea is to put things that are generic in the main library while things that are very specific to a brand in the connector. When things should go into the main CarConenctivity library I would recommend to have a quick discussion first, I need to keep things as generic as possible in order to make it match for as many connectors for different brands as possible. Still if it is a feature that is likely to be shared among different brands the main library is the right place, because then downstream plugins (like for home assistant) can make easier use of those.
—
Reply to this email directly, view it on GitHub[#88 (reply in thread)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AKXGVGLXZ3NEP44J2UTC42T3YEOAFAVCNFSM6AAAAACHRZ52VGVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTINZRGIYDQMQ].
You are receiving this because you commented.
[Tracking image][https://github.com/notifications/beacon/AKXGVGMZJX2FJVJKIP6U7733YEOAFA5CNFSM6AAAAACHRZ52VGWGG33NNVSW45C7OR4XAZNRIRUXGY3VONZWS33OINXW23LFNZ2KUY3PNVWWK3TUL5UWJTQA4B6RE.gif]
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi Till,
thanks for this great project and your contributions. Could you give us some kind of outlook on how much we can expect this project will progress in the next months?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions