Use ECs and joininfo when checking the need for Ordered Append #8994
+737
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment we go over the parse tree to collect these clauses independently. This seems excessive, because during the hypertable expansion all this data is already prepared by the Postgres planner.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8994 +/- ##
==========================================
+ Coverage 82.53% 82.59% +0.05%
==========================================
Files 249 249
Lines 48510 48544 +34
Branches 12388 12393 +5
==========================================
+ Hits 40040 40096 +56
- Misses 3510 3539 +29
+ Partials 4960 4909 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@erimatnor, @fabriziomello: please review this pull request.
|
akuzm
commented
Dec 1, 2025
| -> Materialize (actual rows=10.00 loops=1) | ||
| -> Merge Append (actual rows=3.00 loops=1) | ||
| Sort Key: m3."time" | ||
| -> Custom Scan (ChunkAppend) on metrics_space m3 (actual rows=3.00 loops=1) |
Member
Author
There was a problem hiding this comment.
Looks like the old check failed in some cases, so now we're getting more efficient plans.
natalya-aksman
approved these changes
Dec 1, 2025
svenklemm
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we go over the parse tree to collect these clauses independently. This seems excessive, because during the hypertable expansion all this data is already prepared by the Postgres planner.
Related to #8987 and #8706
Disable-check: force-changelog-file