Skip to content

Commit 1af80a9

Browse files
committed
Added test for log.Type, fixed usage of deprecated methods in test
1 parent 4ff216b commit 1af80a9

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

test/test_geocaching.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ def test_geocode(self):
120120
ref_point = Point(49.74774, 13.37752)
121121
self.assertLess(great_circle(self.g.geocode("Pilsen"), ref_point).miles, 10)
122122

123-
def test_load_cache(self):
124-
c = self.g.load_cache("GC4808G")
123+
def test_get_cache(self):
124+
c = self.g.get_cache("GC4808G")
125125
self.assertEqual("Nekonecne ticho", c.name)
126126

127-
def test_load_trackable(self):
128-
t = self.g.load_trackable("TB1KEZ9")
127+
def test_get_trackable(self):
128+
t = self.g.get_trackable("TB1KEZ9")
129129
self.assertEqual("Lilagul #2: SwedenHawk Geocoin", t.name)
130130

131131
def test_post_log(self):

test/test_log.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from pycaching.errors import ValueError as PycachingValueError
77

88

9-
class TestProperties(unittest.TestCase):
9+
class TestLog(unittest.TestCase):
1010

1111
def setUp(self):
1212
self.l = Log(type="found it", text="text", visited="2012-02-02", author="human")
@@ -37,3 +37,14 @@ def test_visited(self):
3737

3838
def test_author(self):
3939
self.assertEqual(self.l.author, "human")
40+
41+
42+
class TestType(unittest.TestCase):
43+
44+
def test_from_string(self):
45+
with self.subTest("valid type"):
46+
self.assertEqual(Type.found_it, Type.from_string("found it"))
47+
48+
with self.subTest("invalid type"):
49+
with self.assertRaises(PycachingValueError):
50+
Type.from_string("invalid type")

0 commit comments

Comments
 (0)