Skip to content

fix(PM-2540): removed isAIReviewer from challenge schema #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(PM-2540): removed isAIReviewer from challenge schema #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions prisma/challenge.schema.prisma
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,15 +619,15 @@ model DefaultChallengeReviewer {
typeId String
trackId String
// Reviewer configuration (mirrors ChallengeReviewer)
scorecardId String
scorecardId String?
Copy link

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
Changing scorecardId from String to String? makes it nullable. Ensure that the application logic correctly handles cases where scorecardId is null, as this could lead to unexpected behavior if not properly managed.

isMemberReview Boolean
memberReviewerCount Int?
phaseName String
fixedAmount Float? @default(0)
baseCoefficient Float?
incrementalCoefficient Float?
opportunityType ReviewOpportunityTypeEnum?
isAIReviewer Boolean
aiWorkflowId String?
Copy link

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The addition of aiWorkflowId as String? introduces a nullable field. Verify that any logic dependent on aiWorkflowId being non-null is updated to handle null values appropriately to avoid potential null reference errors.

// Default for whether to open a public review opportunity for this reviewer when a challenge is created
shouldOpenOpportunity Boolean @default(true)

Expand Down