PM-589 Improve skills UI #1052
Merged
PM-589 Improve skills UI #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return ( | ||
| <div className={styles.skillsContainer}> | ||
| {visibleSkills.map(skill => ( | ||
| <div key={skill.id} className={styles.skillPill}> |
There was a problem hiding this comment.
Consider specifying the type for skill in the map function to improve type safety and readability.
| {remainingSkills.length > 0 && ( | ||
| <div | ||
| className={styles.skillPill} | ||
| title={remainingSkills.map(skill => skill.name) |
There was a problem hiding this comment.
Using Array.prototype.join without a separator defaults to a comma, which is fine here, but it might be clearer to explicitly specify the separator as ', ' for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-589
What's in this PR?
Only show 3 skills and show a counter with tooltip for the rest