Pm 1496 Show other payment type in opportunity listing #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| propertyName: 'paymentType', | ||
| type: 'text', | ||
| renderer: (copilotOpportunity: CopilotOpportunity) => ( | ||
| <div> |
There was a problem hiding this comment.
Consider using a more descriptive variable name for copilotOpportunity in the renderer function to improve readability, especially if the function grows in complexity.
| type: 'text', | ||
| renderer: (copilotOpportunity: CopilotOpportunity) => ( | ||
| <div> | ||
| {copilotOpportunity.paymentType === 'standard' |
There was a problem hiding this comment.
The conditional logic could be simplified using a ternary operator directly in the JSX expression. Consider using: {copilotOpportunity.paymentType === 'standard' ? copilotOpportunity.paymentType : copilotOpportunity.otherPaymentType}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1496
What's in this PR?