Skip to content

PM-1270 Filter inactive projects in copilot request form #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himaniraghav3 merged 2 commits into from
Aug 5, 2025
Merged

PM-1270 Filter inactive projects in copilot request form #1174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
858ae52
PM-1270 Filter inactive projects in copilot request form
himaniraghav3 Aug 4, 2025
fb804da
Update variable name
himaniraghav3 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/apps/copilots/src/pages/copilot-request-form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const CopilotRequestForm: FC<{}> = () => {
const [formErrors, setFormErrors] = useState<any>({})
const [paymentType, setPaymentType] = useState<string>('')
const [projectFromQuery, setProjectFromQuery] = useState<Project>()
const isActiveProject = ['active', 'approved', 'draft', 'new']
Copy link

@github-actions github-actions bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable isActiveProject is intended to be a list of statuses, but the name suggests it might be a boolean. Consider renaming it to something like activeProjectStatuses to better reflect its purpose.


const { data: copilotRequestData }: CopilotRequestResponse = useCopilotRequest(routeParams.requestId)

Expand Down Expand Up @@ -114,7 +115,13 @@ const CopilotRequestForm: FC<{}> = () => {
label: string;
value: string;
}>> {
const response = await getProjects(inputValue)
const response = await getProjects(inputValue, {
filter: {
status: {
$in: [isActiveProject],
Copy link

@github-actions github-actions bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $in operator is typically used for arrays, but isActiveProject seems to be a single value. Consider using $eq if isActiveProject is a single status value.

},
},
})
return response.map(project => ({ label: project.name, value: project.id }))
}

Expand Down
4 changes: 2 additions & 2 deletions src/apps/copilots/src/services/projects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ export const getProject = (projectId: string): Promise<Project> => {
return xhrGetAsync<Project>(url)
}

export const getProjects = (search?: string, filter?: any): Promise<Project[]> => {
const params = { name: `"${search}"`, ...filter }
export const getProjects = (search?: string, config?: {filter: any}): Promise<Project[]> => {
Copy link

@github-actions github-actions bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming the filter property in the config parameter to something more descriptive, such as projectFilter, to improve code readability and clarity.

const params = { name: search, ...config?.filter }
Copy link

@github-actions github-actions bot Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name parameter should be wrapped in quotes only if necessary. Ensure that the API expects the name parameter without quotes, or adjust accordingly.

const url = buildUrl(baseUrl, params)
return xhrGetAsync<Project[]>(url)
}