-
Notifications
You must be signed in to change notification settings - Fork 844
fix(openai): add streaming support for responses.create() api #3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7d9ee85
fix(openai): add streaming support for responses.create() api
galkleinman 9ba78df
missing files
galkleinman 4bcffb8
delete redundant file
galkleinman 9e7db44
delete redundant comments
galkleinman 31ca1c5
fix prompt logging
galkleinman 9930056
missing cassetes
galkleinman a17bdbb
remove comments
galkleinman 05d8fab
fix test
galkleinman 810f34e
fix pr comment for context management
galkleinman 3a594b7
missing files
galkleinman 974ae91
remove non official semconvs
galkleinman df7ca6e
revert unwanted change
galkleinman b576554
wip
galkleinman e5c8eb8
keep current reasoning impl
galkleinman c1cfeb9
revert
galkleinman 1b19abd
clean
galkleinman f480d19
fix tests
galkleinman 6bf70a1
fix another test
galkleinman 272e106
fix another test
galkleinman 8d4d8dc
fix potential issue when closing the stream manually
galkleinman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider accumulating streaming text into a list and then joining the list once (e.g. using
''.join(list)) rather than performing repeated string concatenation. This can improve performance when processing many small chunks.