Skip to content

Conversation

@kvz
Copy link
Member

@kvz kvz commented Oct 27, 2025

Summary

  • short-circuit SSE processing once assembly_finished arrives and close the EventSource cleanly
  • ensure follow-up assembly_error events are ignored after completion, matching expected behaviour
  • add unit + integration coverage that reproduces the regression and exercises a live assembly stream

Testing

  • ./scripts/test-in-docker.sh test --tests com.transloadit.sdk.EventsourceRunnableTest
  • ./scripts/test-in-docker.sh test --tests com.transloadit.sdk.integration.AssemblySseIntegrationTest
  • ./scripts/test-in-docker.sh check

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.77%. Comparing base (3a9bcaf) to head (76d4ddd).

Files with missing lines Patch % Lines
.../java/com/transloadit/sdk/EventsourceRunnable.java 47.36% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #96      +/-   ##
============================================
- Coverage     77.47%   76.77%   -0.70%     
- Complexity      209      211       +2     
============================================
  Files            13       13              
  Lines           759      775      +16     
  Branches         66       68       +2     
============================================
+ Hits            588      595       +7     
- Misses          137      146       +9     
  Partials         34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kvz kvz merged commit 24cd34f into main Oct 27, 2025
3 checks passed
@kvz kvz deleted the no-sse-reconnect-when-done branch October 27, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants