Skip to content

Conversation

@kvz
Copy link
Member

@kvz kvz commented Oct 27, 2025

Summary

  • add an SSE regression test that replays the existing fixture but reorders assembly_finished ahead of the second result to emulate the Android parity scenario
  • adjust legacy SSE assertions to tolerate duplicate events triggered by LaunchDarkly reconnects
  • keep the event loop draining after assembly_finished for a short grace period so late result events are observed

Testing

  • ./scripts/test-in-docker.sh check

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.37%. Comparing base (d7bb207) to head (213227d).

Files with missing lines Patch % Lines
.../java/com/transloadit/sdk/EventsourceRunnable.java 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #98      +/-   ##
============================================
+ Coverage     75.81%   76.37%   +0.55%     
- Complexity      212      217       +5     
============================================
  Files            13       13              
  Lines           794      800       +6     
  Branches         72       75       +3     
============================================
+ Hits            602      611       +9     
+ Misses          155      153       -2     
+ Partials         37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kvz kvz merged commit 3b3477e into main Oct 27, 2025
3 checks passed
@kvz kvz deleted the feat/assert-sse-results branch October 27, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants