Skip to content

Commit 2ec7786

Browse files
committed
fix(connect): test tropic authenticateDevice only for T3W1
1 parent 38d0727 commit 2ec7786

File tree

2 files changed

+23
-6
lines changed

2 files changed

+23
-6
lines changed

packages/connect/e2e/common.setup.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,18 @@ export const initTrezorConnect = async (
220220
// "1.9.3" - skip for FW exact with 1.9.3
221221
// "1.9.3-1.9.6" - skip for FW gte 1.9.3 && lte 1.9.6
222222
// "!T3T1" - skip for specific device model
223+
// "*T3T1" - run only on specific device models
223224
export const skipTest = (rules: string[]) => {
224225
if (!rules || !Array.isArray(rules)) return;
225226
if (!firmware) return;
226227
const fwModel = firmware.substring(0, 1);
227228
const fwMaster = firmware.includes('-main');
228-
const deviceRule = rules.find(skip => skip === '!' + deviceModel);
229-
if (deviceRule) return deviceRule;
229+
const deviceRuleNegative = rules.find(skip => skip === '!' + deviceModel);
230+
if (deviceRuleNegative) return deviceRuleNegative;
231+
232+
const anyDeviceRulePositive = rules.find(skip => skip.startsWith('*'));
233+
const deviceRulePositive = rules.find(skip => skip === '*' + deviceModel);
234+
if (anyDeviceRulePositive && !deviceRulePositive) return anyDeviceRulePositive;
230235

231236
const rule = rules
232237
.filter(skip => skip.substring(0, 1) === fwModel || skip.substring(1, 2) === fwModel) // filter rules only for current model

packages/connect/e2e/tests/device/authenticateDevice.test.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ describe('TrezorConnect.authenticateDevice', () => {
3838
),
3939
};
4040

41-
conditionalTest(['!T2T1', '!T1B1'], 'validation successful', async () => {
41+
conditionalTest(['*T3W1'], 'validation successful - tropic', async () => {
4242
const result = await TrezorConnect.authenticateDevice({
4343
config,
4444
});
@@ -54,6 +54,20 @@ describe('TrezorConnect.authenticateDevice', () => {
5454
});
5555
});
5656

57+
conditionalTest(['*T3T1', '*T3B1', '*T2B1'], 'validation successful - optiga', async () => {
58+
const result = await TrezorConnect.authenticateDevice({
59+
config,
60+
});
61+
62+
expect(result).toMatchObject({
63+
success: true,
64+
payload: {
65+
optigaResult: { valid: true },
66+
tropicResult: null,
67+
},
68+
});
69+
});
70+
5771
conditionalTest(
5872
['!T2T1', '!T1B1'],
5973
'validation unsuccessful (rootPubKey not found)',
@@ -83,14 +97,13 @@ describe('TrezorConnect.authenticateDevice', () => {
8397
success: true,
8498
payload: {
8599
optigaResult: { valid: false, error: 'ROOT_PUBKEY_NOT_FOUND' },
86-
tropicResult: null,
87100
},
88101
});
89102
},
90103
);
91104

92105
conditionalTest(
93-
['!T2T1', '!T1B1'],
106+
['*T3T1', '*T3B1', '*T2B1'],
94107
'sanity check unsuccessful (caPubkey is on blacklist)',
95108
async () => {
96109
const result = await TrezorConnect.authenticateDevice({
@@ -110,7 +123,6 @@ describe('TrezorConnect.authenticateDevice', () => {
110123
success: true,
111124
payload: {
112125
optigaResult: { valid: false, error: 'CA_PUBKEY_BLACKLISTED' },
113-
tropicResult: null,
114126
},
115127
});
116128
},

0 commit comments

Comments
 (0)