chore: change relay test #23390

peter-sanderson · 2025-11-25T22:02:17Z

Adds a test for changeRelayUrl + some refactoring around it.

This is followup on #23401

🔍🖥️ Suite native android test results: View in Currents

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

peter-sanderson · 2025-11-26T19:03:03Z

suite-native/module-dev-utils/src/components/SuiteSyncRelaySettings.tsx

        );

-        if (!originalIsSuiteSyncEnabled) {
-            dispatch((_, getState) => initSuiteSyncNative({ getState }));


This was forgotten, there is nothing to init anymore

peter-sanderson · 2025-11-26T19:03:58Z

suite-native/module-dev-utils/package.json

        "@suite-native/sentry": "workspace:*",
        "@suite-native/settings": "workspace:*",
        "@suite-native/storage": "workspace:*",
-        "@suite-native/suite-sync": "workspace:*",


☝️ important, this shall not be needed at all, all shall use suite-sync from common and call everything against interface

peter-sanderson · 2025-11-26T19:06:44Z

suite-common/suite-sync/src/createSuiteSyncCompositionRoot.ts

+    dispatch: Dispatch;
+};
+
+export const createSuiteSyncCompositionRoot = (


This is important concept.

We can have modules (suite-sync) that can (shall?) handle their composition in isolatation. So the main app is not polluted by 1000 servicies from it.

cc @vojtatranta

Yes , logicaly "vztyčna plocha" should be minimal - the interaction between this "suit sync module" and the rest of the app.

Logically then, anything that doesn't need to be called from outside shouldn't be there. However, it doesn't solve our problem with that Big Extradependencies that needs to know about these.

Yea, it does not solve problem with Big ExtraDependencies, because they are the problem. They are not composition root, they are the Service-Locator.

They create inherent circular dependency.

If you have object that contain EVERYTHING and you want to use it as type SOMEWHERE, that SOMEWHERE is already referenced in EVERTHING, because it is fucking EVERYHING 🤣

packages/suite/src/views/settings/SettingsDebug/SuiteSyncSettings.tsx

peter-sanderson · 2025-11-27T21:12:35Z

packages/suite/src/views/settings/SettingsDebug/SuiteSyncSettings.tsx

    const [isLoading, setIsLoading] = useState(false);

+    const dispatch = useDispatch();
+    const { suiteSync } = useServices();


This is how to use dependencies/servicies in component. This can be improved, this is very simple solution.

Ideally components shall have defined dependencies as well, but it is probably not very doable in React

Lemonexe · 2025-11-28T16:12:32Z

suite-common/wallet-core/src/device/deviceSelectors.ts

+        }
+
+        return acc;
+    }, [] as SuiteSyncOwner[]);


this would be appropriate as a memoizedSelector

trezor-bot · 2025-11-29T09:48:04Z

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

trezor-bot · 2025-11-30T08:26:42Z

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

feat(suite): add option to pass extra dependencies factory to store and as extra thunk parameter and use it freely also from react context chore: change Relay Test # Conflicts: # suite-native/suite-sync/package.json # suite/suite-sync/package.json # yarn.lock

Lemonexe

LGTM

Base automatically changed from refactor-dependency-injection-in-evolu to develop November 26, 2025 09:56

peter-sanderson force-pushed the relay-tests branch from bd05de6 to be44f4f Compare November 26, 2025 17:56

peter-sanderson changed the base branch from develop to extra-dependencies-factory November 26, 2025 17:56

peter-sanderson force-pushed the relay-tests branch from be44f4f to fd6b32d Compare November 26, 2025 18:42

peter-sanderson changed the title ~~chore: WIP change relay tests~~ chore: change relay test Nov 26, 2025

peter-sanderson added this to Evolu - Suite Sync Nov 26, 2025

peter-sanderson requested a review from vojtatranta November 26, 2025 18:43

peter-sanderson self-assigned this Nov 26, 2025

peter-sanderson force-pushed the relay-tests branch from fd6b32d to 9ea2a73 Compare November 26, 2025 19:02

peter-sanderson commented Nov 26, 2025

View reviewed changes

peter-sanderson force-pushed the relay-tests branch from 9ea2a73 to 8bab759 Compare November 26, 2025 19:18

peter-sanderson marked this pull request as ready for review November 26, 2025 19:21

peter-sanderson requested a review from a team as a code owner November 26, 2025 19:21

peter-sanderson force-pushed the extra-dependencies-factory branch from c7220c2 to 376f13c Compare November 26, 2025 20:32

peter-sanderson requested a review from komret as a code owner November 26, 2025 20:32

peter-sanderson force-pushed the extra-dependencies-factory branch from 376f13c to fd3b9b1 Compare November 26, 2025 20:37

peter-sanderson force-pushed the relay-tests branch from 8bab759 to 37e0ed8 Compare November 26, 2025 20:46

peter-sanderson force-pushed the extra-dependencies-factory branch from fd3b9b1 to 1299cb2 Compare November 26, 2025 20:48

OriginalEveres reviewed Nov 27, 2025

View reviewed changes

packages/suite/src/views/settings/SettingsDebug/SuiteSyncSettings.tsx Outdated Show resolved Hide resolved

packages/suite/src/views/settings/SettingsDebug/SuiteSyncSettings.tsx Outdated Show resolved Hide resolved

Base automatically changed from extra-dependencies-factory to develop November 27, 2025 21:00

peter-sanderson force-pushed the relay-tests branch from 37e0ed8 to f228d8b Compare November 27, 2025 21:08

peter-sanderson commented Nov 27, 2025

View reviewed changes

peter-sanderson force-pushed the relay-tests branch from f228d8b to 2f550d0 Compare November 27, 2025 21:13

peter-sanderson mentioned this pull request Nov 27, 2025

Dependency Injection via Functions and Composition Tree #23463

Open

peter-sanderson changed the base branch from develop to upgrade-evolu2 November 27, 2025 22:23

peter-sanderson force-pushed the relay-tests branch 2 times, most recently from c5a495e to 6f98ce0 Compare November 27, 2025 22:47

Lemonexe reviewed Nov 28, 2025

View reviewed changes

peter-sanderson force-pushed the upgrade-evolu2 branch from 9126e97 to 4659d46 Compare November 29, 2025 08:41

Base automatically changed from upgrade-evolu2 to develop November 29, 2025 09:46

peter-sanderson force-pushed the relay-tests branch from 6f98ce0 to 556e676 Compare November 29, 2025 09:47

peter-sanderson force-pushed the relay-tests branch from 556e676 to 037d37c Compare November 30, 2025 08:26

peter-sanderson mentioned this pull request Nov 30, 2025

Store Servicies #23401

Merged

peter-sanderson force-pushed the relay-tests branch 2 times, most recently from 719fb1f to 037d37c Compare November 30, 2025 08:44

vojtatranta and others added 3 commits November 30, 2025 22:22

fix: empty RelayUrl breaks stuff, add test

6c5c257

fix: correct dev-url for Evolu Relay

3562129

peter-sanderson force-pushed the relay-tests branch from 037d37c to 3562129 Compare November 30, 2025 21:22

Lemonexe self-requested a review December 1, 2025 09:33

Lemonexe approved these changes Dec 1, 2025

View reviewed changes

peter-sanderson merged commit 20bc0cd into develop Dec 1, 2025
37 checks passed

peter-sanderson deleted the relay-tests branch December 1, 2025 10:38

github-project-automation bot moved this to -no status in Evolu - Suite Sync Dec 1, 2025

Uh oh!

chore: change relay test #23390

chore: change relay test #23390

Uh oh!

Conversation

peter-sanderson commented Nov 25, 2025 • edited by trezor-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peter-sanderson Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trezor-bot bot commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trezor-bot bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lemonexe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

peter-sanderson commented Nov 25, 2025 •

edited by trezor-bot bot

Loading

peter-sanderson Nov 26, 2025 •

edited

Loading

trezor-bot bot commented Nov 29, 2025 •

edited

Loading

trezor-bot bot commented Nov 30, 2025 •

edited

Loading