Commit f70af36
Merge LM-Eval dev branch (#337)
* Add lm-eval-service controller (#258)
* feat: Initial database support (#246)
* Initial database support
- Add status checking
- Add better storage flags
- Add spec.storage.format validation
- Add DDL
-Add HIBERNATE format to DB (test)
- Update service image
- Revert identifier to DATABASE
- Update CR options (remove mandatory data)
* Remove default DDL generation env var
* Update service image to latest tag
* Add migration awareness
* Add updating pods for migration
* Change JDBC url from mysql to mariadb
* Fix TLS mount
* Revert images
* Remove redundant logic
* Fix comments
* feat: Add TLS certificate mount on ModelMesh (#255)
* feat: Add TLS certificate mount on ModelMesh
* Revert from http to https until kserve/modelmesh#147 is merged
* Add lm-eval-service controller
refactor the existing TrustyAIService controller and
add LMEvalService controller
Signed-off-by: Yihong Wang <[email protected]>
---------
Signed-off-by: Yihong Wang <[email protected]>
Co-authored-by: Rui Vieira <[email protected]>
* fix: Fix typo in operator's arguments (#261)
Operator's arguments changed from `--eanble-services` to `--enable-services`.
trustyai.opendatahub.io_lmevaljobs.yaml and zz_generated.deepcopy.go regenerated.
* feat: Add LMES driver build to GHA (#272)
* sync: sync dev/lm-eval with main branch (#271)
* feat: Initial database support (#246)
* Initial database support
- Add status checking
- Add better storage flags
- Add spec.storage.format validation
- Add DDL
-Add HIBERNATE format to DB (test)
- Update service image
- Revert identifier to DATABASE
- Update CR options (remove mandatory data)
* Remove default DDL generation env var
* Update service image to latest tag
* Add migration awareness
* Add updating pods for migration
* Change JDBC url from mysql to mariadb
* Fix TLS mount
* Revert images
* Remove redundant logic
* Fix comments
* feat: Add TLS certificate mount on ModelMesh (#255)
* feat: Add TLS certificate mount on ModelMesh
* Revert from http to https until kserve/modelmesh#147 is merged
* Pin oc version, ubi version (#263)
* Restore checkout of trustyai-exp (#265)
* Add operator installation robustness (#266)
* fix: Skip InferenceService patching for KServe RawDeployment (#262)
* feat: ConfigMap key to disable KServe Serverless configuration (#267)
* feat: Add support for custom certificates in database connection (#259)
* Add TLS endpoint for ModelMesh payload processors. (#268)
Keep non-TLS endpoint for KServe Serverless (disabled by default)
---------
Signed-off-by: Yihong Wang <[email protected]>
Co-authored-by: Rui Vieira <[email protected]>
Co-authored-by: Rob Geada <[email protected]>
* Weekly sync up of dev/lm-eval branch (#278)
* feat: Initial database support (#246)
* Initial database support
- Add status checking
- Add better storage flags
- Add spec.storage.format validation
- Add DDL
-Add HIBERNATE format to DB (test)
- Update service image
- Revert identifier to DATABASE
- Update CR options (remove mandatory data)
* Remove default DDL generation env var
* Update service image to latest tag
* Add migration awareness
* Add updating pods for migration
* Change JDBC url from mysql to mariadb
* Fix TLS mount
* Revert images
* Remove redundant logic
* Fix comments
* feat: Add TLS certificate mount on ModelMesh (#255)
* feat: Add TLS certificate mount on ModelMesh
* Revert from http to https until kserve/modelmesh#147 is merged
* Pin oc version, ubi version (#263)
* Restore checkout of trustyai-exp (#265)
* Add operator installation robustness (#266)
* fix: Skip InferenceService patching for KServe RawDeployment (#262)
* feat: ConfigMap key to disable KServe Serverless configuration (#267)
* feat: Add support for custom certificates in database connection (#259)
* Add TLS endpoint for ModelMesh payload processors. (#268)
Keep non-TLS endpoint for KServe Serverless (disabled by default)
* fix: Correct maxSurge and maxUnavailable (#275)
* feat: Add support for custom DB names (#257)
* feat: Add support for custom DB names
* fix: Correct custom DB name
---------
Signed-off-by: Yihong Wang <[email protected]>
Co-authored-by: Rui Vieira <[email protected]>
Co-authored-by: Rob Geada <[email protected]>
* Driver updates job's status periodically (#280)
The driver periodically update the LMEvalJob.Status.Message field
with the outputs from the lm-eval. The message pattern the driver
captures is like `Running text generation: 81%|`. Then users
can use this information to check the progress of the job.
Signed-off-by: Yihong Wang <[email protected]>
* Add Dockerfile for LMES job image (#276)
Add Dockerfile for LMES job image and the needed files
Signed-off-by: Yihong Wang <[email protected]>
* feat: Add overlays (#283)
* feat: Add overlays
* Remove redundant lmes-tas overlay. Change job image name.
* Add job image build (#284)
* Change job image use midstream lm-evaluation-harness (#285)
* feat: support batch size (#290)
Add batch size support in the LMEvalJob which
leverages the `--batch_size` in the `lm-evaluation-harness`.
This only affects the local models. The `--bath_size` doesn't
work for remote inference APIs.
Signed-off-by: Yihong Wang <[email protected]>
* Add the `openai` package into the lmes job image (#292)
update the LMES job's Dockerfile to include the
`openai` package.
Signed-off-by: Yihong Wang <[email protected]>
* fix: fix dependency error in the job image (#296)
Split up the unitxt and openai dependencies to
avoid the conflict.
Signed-off-by: Yihong Wang <[email protected]>
* feat: add device detection in lmes driver (#298)
Added a new feature in LMES driver to detect the available
devices by using the PyTorch API. This feature can be disabled
by passing the `--detect-device false` option.
Signed-off-by: Yihong Wang <[email protected]>
* feat: support unitxt recipes (#301)
Add new fields in the CRD to support unitxt recipes and
leverage the driver to create corresponding yaml files
of the unitxt recipes.
Signed-off-by: Yihong Wang <[email protected]>
* feat: support custom dataset (#309)
Updated the CRD data struct to allow users to specify a custom Unitxt card in
JSON format. The custom Unitxt card is equivalent to a custom dataset
definition. Also restructured and updated the CRD to support Volumes,
VolumeMounts, Env, Resources, Labels, and Annotations.
Signed-off-by: Yihong Wang <[email protected]>
* feat: new pulling mechanism for job statuses (#314)
Update the driver to keep running even the user program
finishes. The driver provides two APIs:
- GetStatus(): retrieve job status
- Shutdown(): properly tear down the driver
In the controller side, it uses `pod/exec` resource
to run the driver command to invoke the driver APIs
to retrieve the job status and shutdown the driver
when job is done.
Signed-off-by: Yihong Wang <[email protected]>
* Move operator's cmd/operator/main.go to cmd/main.go to keep operator-sdk compatibility (#295)
* Remove hardcoded job's user ID (#322)
* Fix mkdir command in Job dockerfile (#330)
* Refactor some lmesreconcile methods (#323)
* Refactor lmes reconcile optoins
Signed-off-by: ted chang <[email protected]>
* Update controllers/lmes/lmevaljob_controller.go
Co-authored-by: Yihong Wang <[email protected]>
* Update controllers/lmes/lmevaljob_controller.go
Co-authored-by: Yihong Wang <[email protected]>
Signed-off-by: ted chang <[email protected]>
---------
Signed-off-by: ted chang <[email protected]>
Co-authored-by: Yihong Wang <[email protected]>
* tidy: clean up lmes-job image (#333)
remove BAM related packages and patch.
Signed-off-by: Yihong Wang <[email protected]>
* Enable job suspend for Kueue (#317)
* Refactor lmes reconcile optoins
Signed-off-by: ted chang <[email protected]>
* Update controllers/lmes/lmevaljob_controller.go
Co-authored-by: Yihong Wang <[email protected]>
* Update controllers/lmes/lmevaljob_controller.go
Co-authored-by: Yihong Wang <[email protected]>
Signed-off-by: ted chang <[email protected]>
* Enable job suspend for Kueue
Signed-off-by: ted chang <[email protected]>
---------
Signed-off-by: ted chang <[email protected]>
Co-authored-by: Yihong Wang <[email protected]>
* Add overlay placeholders for main merge (#334)
* sync: sync up dev/lm-eval branch with main branch (#336)
* [CI] Run tests from trustyai-tests (#279)
* Change Dockerfile to clone trustyai-tests
* Add PYTEST_MARKERS env and remove TESTS_REGEX
* RHOAIENG-12274: Update operator's overlays (#287)
* Update operator's overlays
* Update kustomization.yaml
* Add devflag printout to GH Action comment (#289)
* Add timeout loop to DSC install (#305)
* RHOAIENG-13625: Add DBAvailable status to CR (#304)
* Add DBAvailable status to CR
* Remove probes
* Add KServe destination rule for Inference Services in the ServiceMesh (#315)
* Add DestinationRule creation for KServe serverless
* Add permissions for destination rules
* Add role for destination rules
* Add missing role for creating destination rules
* Fix spacing in DestinationRule template
* Add check if DestinationRule CRD is present before creating it (#316)
* Add check for DestinationRule CRD
* Add API extensions to operator's scheme
* Add permission for CRD resource
* Fix operator metrics service target port (#320)
* Add readiness probes (#312)
* Enable KServe serverless in the rhoai overlay (#321)
* Update overlay images (#331)
* Add correct CA cert to JDBC (#324)
* Add correct CA cert to JDBC
* Add require SSL
* Support for VirtualServices for InferenceLogger traffic (#332)
* Generate KServe Inference Logger in conformance with DestinationRule and VirtualService
* Add VirtualService creation for models in the mesh
* Add permissions for VirtualServices
* Update manifests for VirtualServices
* Fix VirtualServiceName variable
* fix yaml linter after the sync
Signed-off-by: Yihong Wang <[email protected]>
* tidy the go.mod and go.sum as well
Signed-off-by: Yihong Wang <[email protected]>
---------
Signed-off-by: Yihong Wang <[email protected]>
Co-authored-by: Adolfo Aguirrezabal <[email protected]>
Co-authored-by: Rui Vieira <[email protected]>
Co-authored-by: Rob Geada <[email protected]>
Co-authored-by: Rui Vieira <[email protected]>
---------
Signed-off-by: Yihong Wang <[email protected]>
Signed-off-by: ted chang <[email protected]>
Co-authored-by: Yihong Wang <[email protected]>
Co-authored-by: Rob Geada <[email protected]>
Co-authored-by: ted chang <[email protected]>
Co-authored-by: Adolfo Aguirrezabal <[email protected]>1 parent ddd093a commit f70af36
File tree
83 files changed
+7730
-340
lines changed- .github/workflows
- api
- lmes/v1alpha1
- tas/v1alpha1
- cmd
- lmes_driver
- config
- base
- crd
- bases
- manager
- overlays
- lmes
- odh
- rhoai
- rbac
- controllers
- constants
- lmes
- driver
- tas
- templates
- service
- utils
- patch/lmes
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
83 files changed
+7730
-340
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
| |||
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
| 69 | + | |
| 70 | + | |
67 | 71 | | |
68 | 72 | | |
69 | 73 | | |
70 | 74 | | |
71 | 75 | | |
| 76 | + | |
| 77 | + | |
72 | 78 | | |
73 | 79 | | |
74 | 80 | | |
75 | 81 | | |
76 | 82 | | |
| 83 | + | |
| 84 | + | |
77 | 85 | | |
78 | | - | |
| 86 | + | |
79 | 87 | | |
80 | 88 | | |
81 | 89 | | |
82 | 90 | | |
83 | 91 | | |
84 | | - | |
| 92 | + | |
85 | 93 | | |
86 | | - | |
| 94 | + | |
87 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
88 | 104 | | |
89 | 105 | | |
90 | 106 | | |
| |||
127 | 143 | | |
128 | 144 | | |
129 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
130 | 150 | | |
131 | 151 | | |
132 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
10 | 13 | | |
11 | 14 | | |
12 | 15 | | |
| |||
111 | 114 | | |
112 | 115 | | |
113 | 116 | | |
114 | | - | |
| 117 | + | |
115 | 118 | | |
116 | 119 | | |
117 | 120 | | |
118 | | - | |
| 121 | + | |
119 | 122 | | |
120 | 123 | | |
121 | 124 | | |
| |||
182 | 185 | | |
183 | 186 | | |
184 | 187 | | |
185 | | - | |
| 188 | + | |
186 | 189 | | |
187 | 190 | | |
188 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
23 | 36 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
0 commit comments