-
-
Notifications
You must be signed in to change notification settings - Fork 10
Added dnd - First Phase #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v1.7.0
Are you sure you want to change the base?
Added dnd - First Phase #273
Conversation
|
This was actually a very complicated. But since you have started it, now it feels simple. I don't know what is the best way to implement this. But your code actually seems clean and a very good approach to proceed for now. But still I am not sure yet as a proper dnd manager will be required to be crafted so it's easier to manage and scale in the future. Since you have commenced with this feature I have finally started the discussion which was in my head and in which I was thinking deeply for a while now : #275 Ill add reviews wherever I can, but I think mostly I'll be merging this in a new branch and will start working on this in a new branch first. Because to preserve the manual order inside the columns, I have decided to save the ids of the task as the column data. And this IDs for the tasks are actually going to be new ids, which will persist on to the tasks as task property. Here is the FR for this : #254 Will keep this hold for now, till I release the |
|
Thank you very much for working on this, because I was really scared of this feature. But now I'm confident that by this release, we will be able to finish with defining all the rulesets I have mentioned in the discussion and few more if I have missed and then build the best dnd manager to finally implement this feature properly. |
|
It's really complicated. Especially if we considerd that we have markdown files, json files, several types of columns. A little complicated, and almost imposible to make a "100% free bug" release in the first stage. But... if we never start, we will never finish 🤗 But yes, dnd is the most interesting and the most complicated task in the project (IMHO) |
|
I have already merged the commits from these PR into the branch Will still keep this PR open for future discussions and announcements. |
Added first phase of drag and drop