Merge pull request #86 from fcgravalos/fcgravalos/bugfix_nil_client

Wiston999 · web-flow · commit c293ef29ed58 · 2022-04-04T13:27:05.000+02:00
fix nil pointer dereference bug in controller's regular kubernetes client
diff --git a/config/default/manager_image_patch.yaml b/config/default/manager_image_patch.yaml
@@ -8,5 +8,5 @@ spec:
     spec:
       containers:
       # Change the value of image field below to your controller image URL
-      - image: registry.hub.docker.com/tuentitech/secrets-manager:v2.0.0
+      - image: registry.hub.docker.com/tuentitech/secrets-manager:v2.0.1
         name: manager
diff --git a/deploy/version/version.properties b/deploy/version/version.properties
@@ -1 +1 @@
-version=v2.0.0
+version=v2.0.1
diff --git a/main.go b/main.go
@@ -177,6 +177,7 @@ func main() {
 	}
 
 	if err = (&controllers.SecretDefinitionReconciler{
+		Client:               mgr.GetClient(),
 		Backend:              *backendClient,
 		APIReader:            mgr.GetAPIReader(),
 		Log:                  ctrl.Log.WithName("controllers").WithName("SecretDefinition"),

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,7 @@ func main() {`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`if err = (&controllers.SecretDefinitionReconciler{`
	`180`	`+ Client: mgr.GetClient(),`
`180`	`181`	`Backend: *backendClient,`
`181`	`182`	`APIReader: mgr.GetAPIReader(),`
`182`	`183`	`Log: ctrl.Log.WithName("controllers").WithName("SecretDefinition"),`