Merge pull request #10 from tunabay/dev

Use Go 1.17

Author: tunabay

.ci/golangci-lint.yml

@@ -1,6 +1,6 @@
 run:
   timeout: 5m
-  tests: false
+  tests: true
   fast: false
   skip-dirs-use-default: true
   print-issued-lines: true
@@ -12,7 +12,6 @@ linters:
   enable:
     - deadcode
     - errcheck
-    - errname
     - gosimple
     - govet
     - ineffassign
@@ -21,9 +20,11 @@ linters:
     - typecheck
     - unused
     - varcheck
+
     - asciicheck
     - bodyclose
     - dogsled
+    - errname
     - errorlint
     - exportloopref
     - forbidigo
@@ -56,7 +57,40 @@ linters:
     - whitespace
     - wrapcheck
 
+linters-settings:
+  gofumpt:
+    lang-version: "1.17"
+  gosimple:
+    go: "1.17"
+  staticcheck:
+    go: "1.17"
+  stylecheck:
+    go: "1.17"
+  unused:
+    go: "1.17"
+
+  misspell:
+    locale: US
+
+  errcheck:
+    exclude-functions:
+      - io/ioutil.ReadFile
+      - io.Copy(*bytes.Buffer)
+      - io.Copy(os.Stdout)
+      - (*github.com/tunabay/go-bitarray.Builder).WriteBit
+      - (*github.com/tunabay/go-bitarray.Builder).WriteByte
+      - (*github.com/tunabay/go-bitarray.Builder).WriteBitArray
+
 issues:
-  max-issues-per-linter: 1023
-  max-same-issues: 255
+  max-issues-per-linter: 0
+  max-same-issues: 0
   fix: false
+
+  exclude-use-default: true
+  exclude-rules:
+
+    # ignore in unit tests
+    - linters: [ gosec, goerr113, ifshort ]
+      path: "_test\\.go$"
+    - linters: [ staticcheck ]
+      text: "^SA9003: empty branch"

bitarray_sha512_example_test.go

@@ -34,7 +34,7 @@ func ExampleBitArray_SHA384() {
 	// c6b08368812f4f02aaf84c1b8fcd549f53099816b212fe68cb32f6d73563fae8cec52b96051ade12ba8f3c6a6e98a616
 }
 
-func ExampleBitArray_SHA512_256() {
+func ExampleBitArray_SHA512_256() { //nolint: govet // false positive for _256 suffix
 	ba1 := bitarray.MustParse("0000")
 	ba2 := bitarray.MustParse("00000")
 

go.mod

@@ -1,5 +1,5 @@
 module github.com/tunabay/go-bitarray
 
-go 1.16
+go 1.17
 
 require gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b

util.go

@@ -6,7 +6,6 @@ package bitarray
 
 import (
 	"fmt"
-	"reflect"
 	"unsafe"
 )
 
@@ -344,18 +343,7 @@ func allocByteSlice(nBytes int) []byte {
 }
 
 func asUint64Slice(b []byte) []uint64 {
-	// s := (*[cap(b)>>3]uint64)(unsafe.Pointer(&b[0]))[:]
-
-	n := (len(b) + 7) >> 3
-	s := make([]uint64, 0)
-	h := (*reflect.SliceHeader)(unsafe.Pointer(&s))
-	h.Data, h.Len, h.Cap = uintptr(unsafe.Pointer(&b[0])), n, n
-
-	// Since go1.17
-	// 2021-08-21: golangcilint v1.42.0 does not support go1.17?
-	// s := unsafe.Slice((*uint64)(unsafe.Pointer(&b[0])), (len(b)+7)>>3)
-
-	return s
+	return unsafe.Slice((*uint64)(unsafe.Pointer(&b[0])), (len(b)+7)>>3)
 }
 
 func fill00(b []byte) {