Publish C libraries during release #2428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bencher Report
jneem
force-pushed
the
publish-libraries
branch
7 times, most recently
from
015a233 to
43f4ed9
Compare
jneem
force-pushed
the
publish-libraries
branch
from
43f4ed9 to
f485a78
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds precompiled C libraries (static and dynamic) to the release artifacts across all supported platforms (Linux x86_64/arm64, macOS arm64, and Windows x86_64). The changes enable downstream projects, particularly the go bindings, to use these precompiled libraries.
- Builds and publishes C library artifacts (.a static libraries and .so/.dylib/.dll dynamic libraries) for Linux, macOS, and Windows
- Includes the nickel_lang.h header file in Linux artifacts
- Configures Windows builds to use MinGW toolchain for cgo compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bash ./scripts/shrink_archive.sh -o libnickel_lang-x86_64-windows-mingw.a \ | ||
| ./target/x86_64-pc-windows-gnu/release/libnickel_lang.a | ||
| cp ./target/x86_64-pc-windows-gnu/release/nickel_lang.dll libnickel_lang-x86_64-windows-mingw.dll | ||
| - name: "Upload binaries as release assets" |
There was a problem hiding this comment.
[nitpick] The step name should be updated to "Upload binaries/libraries as release assets" to match the updated names in the Linux (line 51) and macOS (line 121) jobs, since this step now uploads both binaries and libraries.
Suggested change
| - name: "Upload binaries as release assets" | |
| - name: "Upload binaries/libraries as release assets" |
Co-authored-by: Copilot <[email protected]>
yannham
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds precompiled C libraries to the release artifacts. I've tested here that the resulting static libraries pass the go bindings' tests.