Skip to content

Conversation

@alexcardell
Copy link

@alexcardell alexcardell commented Feb 23, 2024

Supercedes #456

  • Adds lambda-natchez module
  • Adds lambda-otel4s module
    • Traces lambdas with semantic conventions applied
  • Adds otel4s examples
  • Add scalafix migration to port natchez package imports -- (removes previous version scalafix migrations)

This is targeting otel4s 0.14.x 0.13.x 0.12.x 0.11.x 0.10.x 0.9.x 0.8.x 0.7.x 0.6.x 0.5.x

Links

https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/

@alexcardell
Copy link
Author

Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has NoPublish for everything involving the SDK

@alexcardell alexcardell marked this pull request as ready for review March 12, 2024 19:21
@alexcardell alexcardell changed the title WIP: Add lambda-otel4s module Add lambda-otel4s module Mar 12, 2024
@alexcardell
Copy link
Author

@iRevive Updated all the attributes and removed semconv-experimental

Would appreciate another look when you have time

@iRevive
Copy link

iRevive commented Apr 20, 2024

@alexcardell the changes look good.

We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right?

@alexcardell
Copy link
Author

The middleware would be useful for the example, but I don't believe it's necessary otherwise

@iRevive
Copy link

iRevive commented Oct 9, 2024

There is a compatible pre-release of the http4s-otel4s - https://github.com/http4s/http4s-otel4s-middleware/releases/tag/v0.9.0-rc.2.

@keuhdall
Copy link

Hi, is there anything blocking this PR ?

@iRevive
Copy link

iRevive commented Oct 21, 2025

I think we need to wait for a new release of the http4s-otel4s-middleware

@alexcardell
Copy link
Author

It's fixed for 0.13.x

@alexcardell
Copy link
Author

Updated for 0.14.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants