-
-
Notifications
You must be signed in to change notification settings - Fork 50
Add lambda-otel4s module #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6b6999d to
4242256
Compare
|
Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has |
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/FaasAttributes.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/package.scala
Outdated
Show resolved
Hide resolved
|
@iRevive Updated all the attributes and removed semconv-experimental Would appreciate another look when you have time |
|
@alexcardell the changes look good. We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right? |
|
The middleware would be useful for the example, but I don't believe it's necessary otherwise |
This is to allow consumers the choice of natchez or otel4s No breaking changes except requiring a `feral.lambda.natchez._` import
Co-authored-by: Maksym Ochenashko <[email protected]>
|
There is a compatible pre-release of the http4s-otel4s - https://github.com/http4s/http4s-otel4s-middleware/releases/tag/v0.9.0-rc.2. |
|
Hi, is there anything blocking this PR ? |
|
I think we need to wait for a new release of the http4s-otel4s-middleware |
|
It's fixed for 0.13.x |
|
Updated for 0.14.x |
Supercedes #456
This is targeting otel4s 0.14.x
0.13.x0.12.x0.11.x0.10.x0.9.x0.8.x0.7.x0.6.x0.5.xLinks
https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/