-
-
Notifications
You must be signed in to change notification settings - Fork 27
fix(abg): use the release date of the latest version for lastUpdated #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2024
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 19, 2024
Member
|
Can you show me how to reproduce Kotlin being unhappy by the lack of the checksum/release date? I experienced it for version-specific artifacts, but for this artifact I didn't. |
5f291dc to
09633a4
Compare
d81995e to
bf447ca
Compare
Collaborator
Author
|
If you use a version range, it downloads the metadata file to get the list of versions and wants to validate it, then cries if it cannot. |
This was referenced Aug 20, 2024
09633a4 to
cb4a8a3
Compare
bf447ca to
8326892
Compare
cb4a8a3 to
d9a036e
Compare
8326892 to
3ece0b6
Compare
d9a036e to
a7e496f
Compare
3ece0b6 to
a9e554c
Compare
a7e496f to
ef9782d
Compare
a9e554c to
d594493
Compare
65de8a3 to
46fb8ff
Compare
2a83493 to
e2d2901
Compare
46fb8ff to
109d975
Compare
e2d2901 to
380bdea
Compare
109d975 to
3f8d009
Compare
380bdea to
1ce27b6
Compare
3f8d009 to
2ea0adb
Compare
1ce27b6 to
dcb2ca5
Compare
2ea0adb to
f0cc02e
Compare
dcb2ca5 to
a72b66b
Compare
f0cc02e to
12c3675
Compare
a72b66b to
e8c1cd5
Compare
12c3675 to
f7c8535
Compare
e8c1cd5 to
2574b9d
Compare
f7c8535 to
851c826
Compare
2574b9d to
bbbeee6
Compare
bbbeee6 to
715b8df
Compare
851c826 to
779b608
Compare
715b8df to
7d6a173
Compare
779b608 to
a7694a5
Compare
7d6a173 to
39cda66
Compare
39cda66 to
7ca0c8f
Compare
krzema12
approved these changes
Sep 8, 2024
7ca0c8f to
c741439
Compare
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This makes the metadata file content more stable and allows to provide a checksum,
as Kotlin for example is quite unhappy if it finds no checksum or cannot successfully verify it.
Without this every request would produce a different file and thus also a different checksum file,
so the checksum would never match the file contents.