[VAAPI] libva-2.17 breaks video output

[tmn505]

This is to track upstream issue after DRI3 addition: intel/libva#677
Symptoms are black screen without OSD only audio playing.

Example of log output before acquiring stream:
vdr[3334]: video/vaapi: vaPutSurface failed -1

and after acquiring stream:
vdr[3334]: video/vaapi: vaPutSurface failed: unknown libva error

[ua0lnj]

Try test branch and -v va-api-egl.
Need egl libs.

[tmn505]

Hi.
The test branch with -v va-api-egl works on both 2.16 and 2.17 libva versions.

I also tried va-api-glx, it outputs following error on libva 2.17:
vdr[813]: video/glx: vaCopySurfaceGLX failed

while on libva 2.16, the log looks normal but picture looks like this:

[ua0lnj]

For latest driver you can use va-api-egl only. New driver not support subpicture for OSD, and vaCopySurfaceGLX not works with it.
Also look at readme, for va-api-glx use export allow_rgb10_configs=false.
The glx works slow on Intel, and UHD not usable.

[pbiering]

Got hit also after upgrading my test VDR to next to be released Fedora 38 containing also libva-2.17. Can confirm 'test' branch is working by local rebuild of vdr-softhddevice using release 1.10.0 and diff to 'test' branch.

[pbiering]

btw: regarding release number, was this intended to remove the "v" now on 1.10.0?

[ua0lnj]

This is a my mistake.

[pbiering]

@ua0lnj : any reason why 1.10.3 is still not containing EGL related extension from "test" branch? It's required here on Fedora 38 with libva-2.18.0-1 on a "Intel Broxton (Gen9) "

[pbiering]

@ua0lnj : can you at least rebase the "test" branch to 1.10.3?

[tmn505]

@pbiering as workaround link stable softhddevice from master branch to a static older libva library, that way it won't matter what distro provides.
There's PR pending in libva repository intel/libva#716, does that fix the issue with master branch? If yes maybe pointing it to Fedora libva maintainer would solve the issue. I'll do my test later and post result here.

[ua0lnj]

I plan to merge the branches in version 2.0.0, but for this there are still some things that I still have to do that I do not have enough time for.

[pbiering]

@pbiering as workaround link stable softhddevice from master branch to a static older libva library, that way it won't matter what distro provides. There's PR pending in libva repository intel/libva#716, does that fix the issue with master branch? If yes maybe pointing it to Fedora libva maintainer would solve the issue. I'll do my test later and post result here.

Thank you for pointing to the patch, which makes usable toggle visible:

getenv("LIBVA_DRI3_DISABLE")

Now using export LIBVA_DRI3_DISABLE="1" and all is fine with vanilla libva 2.18 and output va-api!

BTW: according to intel_gpu_top, va-api consumes approx. 50% for "Render/3D" while va-api-egl only approx. 25%

[tmn505]

Glad it helped. I my case (master+va-api+patched-libva) there is a picture for h264 or mpeg2 broadcasts but fails on hevc ones with log spamming:

video/vaapi: vaSyncSurface failed
video/vaapi: vaSyncSurface failed: operation failed

With whatever format OSD is not displayed at all and log shows:
video/vaapi: can't find a supported subpicture format

I still use test branch for the time being, works flawlessly.

My system is libva 2.18.0, ffmpeg 6.0 and kernel 6.1.
Output of vainfo:

vainfo: VA-API version: 1.19 (libva 2.18.2)
vainfo: Driver version: Intel iHD driver for Intel(R) Gen Graphics - 23.2.3 ()
vainfo: Supported profile and entrypoints
      VAProfileNone                   : VAEntrypointVideoProc
      VAProfileNone                   : VAEntrypointStats
      VAProfileMPEG2Simple            : VAEntrypointVLD
      VAProfileMPEG2Main              : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointEncSlice
      VAProfileH264Main               : VAEntrypointFEI
      VAProfileH264Main               : VAEntrypointEncSliceLP
      VAProfileH264High               : VAEntrypointVLD
      VAProfileH264High               : VAEntrypointEncSlice
      VAProfileH264High               : VAEntrypointFEI
      VAProfileH264High               : VAEntrypointEncSliceLP
      VAProfileVC1Simple              : VAEntrypointVLD
      VAProfileVC1Main                : VAEntrypointVLD
      VAProfileVC1Advanced            : VAEntrypointVLD
      VAProfileJPEGBaseline           : VAEntrypointVLD
      VAProfileJPEGBaseline           : VAEntrypointEncPicture
      VAProfileH264ConstrainedBaseline: VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
      VAProfileH264ConstrainedBaseline: VAEntrypointFEI
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSliceLP
      VAProfileVP8Version0_3          : VAEntrypointVLD
      VAProfileVP8Version0_3          : VAEntrypointEncSlice
      VAProfileHEVCMain               : VAEntrypointVLD
      VAProfileHEVCMain               : VAEntrypointEncSlice
      VAProfileHEVCMain               : VAEntrypointFEI
      VAProfileHEVCMain10             : VAEntrypointVLD
      VAProfileHEVCMain10             : VAEntrypointEncSlice
      VAProfileVP9Profile0            : VAEntrypointVLD
      VAProfileVP9Profile2            : VAEntrypointVLD

[pbiering]

Mine looks a little bit different, OSD is working fine, DVB-C serves here no free-to-cable HVEC content, so can't test.

ffmpeg-6.0
libva-2.18.0
kernel-6.3.11
intel-media-driver-23.1.6

vainfo: VA-API version: 1.18 (libva 2.18.2)
vainfo: Driver version: Intel iHD driver for Intel(R) Gen Graphics - 23.1.6 ()
vainfo: Supported profile and entrypoints
...

[ua0lnj]

Fedora 40. With LIBVA_DRI3_DISABLE=1 works va-api, va-api-glx, va-api-egl. Without works va-api-egl only. I think the topic can be closed.