Skip to content

Cleanup and refactor course.controller.ts #429

@AdamFipke

Description

@AdamFipke

There's lots of stuff here, but some things I noticed:

  • Many endpoints there are bloated and should be refactored into service functions
  • checkMeIn, checkMeOut, setTaExtraStatus, createQueue could all be moved to queue.controller.ts (and queue.service.ts. Along with moving over tests and reorganizing api/index.ts)
    • Small thing: Some of these have isDisabled in their queue queries and will return 404 if the queue is disabled when it should probably return 400 "queue is disabled" instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions