Skip to content

Conversation

@arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Sep 17, 2025

  • bump golangci-lint to v2
  • bump bump golangci/golangci-lint-action from 6 to 8

passed test: arukiidou/pull/13

  • recommended labels:
    • dependencies Pull requests that update a dependency file
    • github_actions Pull requests that update GitHub Actions code
    • go Pull requests that update Go code

note

fixed 3 lints:

[lint] golangci-lint: .
Error: zapcore/field_test.go:72:2: QF1003: could use tagged switch on o.kind (staticcheck)
	if o.kind == 1 {
	^
Error: zapcore/lazy_with.go:41:4: QF1008: could remove embedded field "Once" from selector (staticcheck)
	d.Once.Do(func() {
	  ^
Error: zaptest/logger_test.go:176:4: QF1008: could remove embedded field "TB" from selector (staticcheck)
	t.TB.Log(m)
	  ^
3 issues:
* staticcheck: 3

additional lints from new PRs

Error: zapcore/lazy_with.go:26:1: File is not properly formatted (gofumpt)
	core   Core

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.54%. Comparing base (4b9cea0) to head (6abb705).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1510      +/-   ##
==========================================
- Coverage   98.61%   98.54%   -0.07%     
==========================================
  Files          53       53              
  Lines        3031     3031              
==========================================
- Hits         2989     2987       -2     
- Misses         34       35       +1     
- Partials        8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arukiidou
Copy link
Contributor Author

@abhinav
Fix gofumpt issues from #1511
Could you please review this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants