Skip to content

Conversation

@shreyashankar
Copy link
Collaborator

@shreyashankar shreyashankar commented Oct 22, 2025

This PR adds a visualization tool for us to generate figures for our papers. Example screenshot:

Screenshot 2025-10-22 at 4 04 02 PM

@cursor
Copy link

cursor bot commented Oct 22, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

cursoragent and others added 2 commits October 22, 2025 21:12
This commit introduces a visual editor for configuring pipelines, allowing users to manipulate blocks, properties, and stacks through a user-friendly interface. The JSON editor remains available as an alternative.

Co-authored-by: ss.shankar505 <[email protected]>
@shreyashankar shreyashankar marked this pull request as ready for review October 22, 2025 23:03
@shreyashankar shreyashankar merged commit 69a1f9a into main Oct 22, 2025
5 checks passed
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 6

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

? "border-destructive"
: ""
}`}
value={String(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Validation Fails for Zero Dimensions

The validation styling for width and height input fields, affecting both main blocks and stack sub-blocks, doesn't appear when the value is 0. This happens because the && operator short-circuits when 0 is evaluated as falsy, preventing the <= 0 check from running.

Additional Locations (3)

Fix in Cursor Fix in Web

const [moved] = srcStack.operators.splice(source.index, 1);
const dstStack = next[dpIdx].operators[dbIdx] as StackOp;
dstStack.operators.splice(destination.index, 0, moved);
setConfig({ pipelines: next });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: State Mutation Causes React UI Inconsistency

The onDragEnd handler directly mutates operators arrays within pipelines and stacks. The shallow copy of pipelines doesn't prevent modification of nested arrays, which can lead to React missing state updates and inconsistent UI.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants