-
Notifications
You must be signed in to change notification settings - Fork 331
Build interactive pipeline visualization editor #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build interactive pipeline visualization editor #437
Conversation
Co-authored-by: ss.shankar505 <[email protected]>
|
Cursor Agent can help with this pull request. Just |
This commit introduces a visual editor for configuring pipelines, allowing users to manipulate blocks, properties, and stacks through a user-friendly interface. The JSON editor remains available as an alternative. Co-authored-by: ss.shankar505 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 6
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| ? "border-destructive" | ||
| : "" | ||
| }`} | ||
| value={String( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Validation Fails for Zero Dimensions
The validation styling for width and height input fields, affecting both main blocks and stack sub-blocks, doesn't appear when the value is 0. This happens because the && operator short-circuits when 0 is evaluated as falsy, preventing the <= 0 check from running.
Additional Locations (3)
| const [moved] = srcStack.operators.splice(source.index, 1); | ||
| const dstStack = next[dpIdx].operators[dbIdx] as StackOp; | ||
| dstStack.operators.splice(destination.index, 0, moved); | ||
| setConfig({ pipelines: next }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: State Mutation Causes React UI Inconsistency
The onDragEnd handler directly mutates operators arrays within pipelines and stacks. The shallow copy of pipelines doesn't prevent modification of nested arrays, which can lead to React missing state updates and inconsistent UI.
This PR adds a visualization tool for us to generate figures for our papers. Example screenshot: