fix: Support .NET 10 RC2+ illink.dll path structure with cross-platform compatibility #21732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility Co-authored-by: jeromelaban <[email protected]>
|
|
Copilot
AI
changed the title
[WIP] Fix Xaml Trimming path issue for net10 rc2
fix: Support .NET 10 RC2+ illink.dll path structure
Nov 2, 2025
Copilot finished work on behalf of
jeromelaban
November 2, 2025 18:01
jeromelaban
reviewed
Nov 2, 2025
…t10' instead of 'Old' Co-authored-by: jeromelaban <[email protected]>
Copilot finished work on behalf of
jeromelaban
November 2, 2025 18:07
github-actions
bot
added
the
area/code-generation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the IL linker path resolution logic to support both .NET 10 RC2+'s new path structure (tools/net/illink.dll) and the legacy pre-.NET 10 structure (tools/net10.0/illink.dll). The change implements a fallback mechanism that tries the new .NET 10 RC2+ path first, then falls back to the version-specific path if the new structure doesn't exist.
- Adds support for .NET 10 RC2+'s simplified IL linker path structure
- Implements backward compatibility with pre-.NET 10 path structures
- Uses an existence check to automatically select the correct path
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21732/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21732/docs/index.html |
jeromelaban
reviewed
Nov 2, 2025
…e trimming test Co-authored-by: jeromelaban <[email protected]>
Copilot
AI
changed the title
fix: Support .NET 10 RC2+ illink.dll path structure
fix: Support .NET 10 RC2+ illink.dll path structure with cross-platform compatibility
Nov 2, 2025
Copilot finished work on behalf of
jeromelaban
November 2, 2025 19:17
jeromelaban
reviewed
Nov 2, 2025
src/SolutionTemplate/5.6/uno56netcurrent/uno56netcurrent/uno56netcurrent.csproj
Outdated
Show resolved
Hide resolved
…ifying project Co-authored-by: jeromelaban <[email protected]>
Copilot finished work on behalf of
jeromelaban
November 2, 2025 19:35
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21732/docs/index.html |
Member
|
@copilot That's great now you also need to add net10.0-browserwasm to uno56netcurrent.csproj. It also needs the files from it needs the |
Co-authored-by: jeromelaban <[email protected]>
Contributor
Author
Added
The structure matches the reference from uno.templates. (0dee6db) Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
jeromelaban
November 2, 2025 19:44
github-actions
bot
added
area/solution-templates
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...olutionTemplate/5.6/uno56netcurrent/uno56netcurrent/Platforms/WebAssembly/wwwroot/web.config
Dismissed
Show dismissed
Hide dismissed
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21732/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21732/docs/index.html |
jeromelaban
reviewed
Nov 2, 2025
Co-authored-by: jeromelaban <[email protected]>
Copilot finished work on behalf of
jeromelaban
November 2, 2025 22:17
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21732/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21732/wasm-skia-net9/index.html |
jeromelaban
approved these changes
Nov 3, 2025
Contributor
|
The build 180645 found UI Test snapshots differences: Details
|
Xiaoy312
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
XAML trimming failed on .NET 10 RC2+ because the
microsoft.net.illink.taskspackage structure changed:.../tools/net10.0/illink.dll.../tools/net/illink.dllSolution:
Modified
Uno.UI.Tasks.targetsto intelligently detect the correct path by checking if the .NET 10 RC2+ structure exists first, then falling back to the pre-.NET 10 structure for backward compatibility. All path constructions now usePath.Combinefor cross-platform compatibility.Changes:
src/SourceGenerators/Uno.UI.Tasks/Content/Uno.UI.Tasks.targetsPath.Combinefor all path constructions to ensure cross-platform compatibility (Linux, macOS, Windows)_Newsuffix from main property (won't be "new" once released)_Oldto_PreNet10for claritydotnet publishwith-p:PublishTrimmed=trueand-p:UnoXamlResourcesTrimming=truedotnet publishwith-p:WasmShellILLinkerEnabled=trueand-p:UnoXamlResourcesTrimming=true-r linux-x64for Linux,-r win-x64for Windows)run-netcore-mobile-template-tests.ps1andrun-net7-template-linux.ps1uno56netcurrenttest project to support WebAssemblynet10.0-browserwasmtarget frameworkPlatforms/WebAssemblyfolder structure with all necessary filesValidation:
✅ Builds successfully
✅ Code review passed
✅ Security check passed
✅ Cross-platform path handling with Path.Combine
✅ CI/CD scripts use publish target with linker enabled for proper trimming validation
✅ WebAssembly platform structure matches uno.templates reference
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.