refactor: implement CharSequence methods as interface defaults

Author: Vynbz

vertx-web-client/src/main/java/io/vertx/ext/web/client/HttpRequest.java

@@ -193,7 +193,9 @@ public interface HttpRequest<T> {
    */
   @Fluent
   @GenIgnore(GenIgnore.PERMITTED_TYPE)
-  HttpRequest<T> putHeader(CharSequence name, CharSequence value);
+  default HttpRequest<T> putHeader(CharSequence name, CharSequence value) {
+    return putHeader(name.toString(), value.toString());
+  }
 
   /**
    * Configure the request to set a new HTTP header with multiple values.
@@ -206,6 +208,25 @@ public interface HttpRequest<T> {
   @GenIgnore(GenIgnore.PERMITTED_TYPE)
   HttpRequest<T> putHeader(String name, Iterable<String> value);
 
+  /**
+   * Configure the request to set a new HTTP header with multiple values using CharSequence.
+   * <p>
+   * This is an overload of {@link #putHeader(String, Iterable)} that accepts CharSequence parameters.
+   *
+   * @param name  the header name
+   * @param value the header value
+   * @return a reference to this, so the API can be used fluently
+   */
+  @Fluent
+  @GenIgnore(GenIgnore.PERMITTED_TYPE)
+  default HttpRequest<T> putHeader(CharSequence name, Iterable<CharSequence> value) {
+    List<String> values = new ArrayList<>();
+    for (CharSequence cs : value) {
+      values.add(cs.toString());
+    }
+    return putHeader(name.toString(), values);
+  }
+
   /**
    * @return The HTTP headers
    */

vertx-web-client/src/main/java/io/vertx/ext/web/client/impl/HttpRequestImpl.java

@@ -231,12 +231,6 @@ public HttpRequest<T> putHeader(String name, String value) {
     return this;
   }
 
-  @Override
-  public HttpRequest<T> putHeader(CharSequence name, CharSequence value) {
-    headers().set(name, value);
-    return this;
-  }
-
   @Override
   public HttpRequest<T> putHeader(String name, Iterable<String> value) {
     headers().set(name, value);

vertx-web-client/src/test/java/io/vertx/ext/web/client/tests/WebClientTest.java

@@ -1255,7 +1255,7 @@ public void testFormUrlEncodedMultipleHeaders() throws Exception {
     startServer();
     MultiMap form = MultiMap.caseInsensitiveMultiMap();
     HttpRequest<Buffer> builder = webClient.post("/somepath");
-    builder.putHeader("bla", Arrays.asList("1", "2"));
+    builder.putHeader((CharSequence) "bla", Arrays.asList("1", "2"));
     builder.sendForm(form).onComplete(onSuccess(resp -> complete()));
     await();
   }
@@ -1485,7 +1485,7 @@ public void testMultipartFormMultipleHeaders() throws Exception {
     startServer();
     HttpRequest<Buffer> builder = webClient.post("somepath");
     MultipartForm form = MultipartForm.create();
-    builder.putHeader("bla", Arrays.asList("1", "2"));
+    builder.putHeader((CharSequence) "bla", Arrays.asList("1", "2"));
     builder.sendMultipartForm(form).onComplete(onSuccess(resp -> complete()));
     await();
   }
@@ -2161,7 +2161,7 @@ public void testMultipleHeaders() throws Exception {
     testRequest(
       client -> client
         .get("somepath")
-        .putHeader("bla", Arrays.asList("1", "2")),
+        .putHeader((CharSequence) "bla", Arrays.asList("1", "2")),
       req -> assertEquals(Arrays.asList("1", "2"), req.headers().getAll("bla")));
   }