Skip to content

Commit dc1d9d1

Browse files
Itou-Ngmayneyao
authored andcommitted
perf: make it concise to hint lacking space_id.
1 parent fe37f18 commit dc1d9d1

File tree

6 files changed

+12
-20
lines changed

6 files changed

+12
-20
lines changed

test/test_create_datasheet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import unittest
22
import warnings
33
from vika import Vika
4-
from . import TEST_TABLE, TEST_API_BASE, TEST_API_TOKEN, TEST_SPACE_ID
4+
from . import TEST_API_BASE, TEST_API_TOKEN, TEST_SPACE_ID
55

66

77
class TestCreateFields(unittest.TestCase):

vika/datasheet/datasheet.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import requests
88

99
from vika.const import API_GET_DATASHEET_QS_SET, DEFAULT_PAGE_SIZE
10-
from vika.exceptions import ErrorSortParams, SpaceInfoLack
10+
from vika.exceptions import ErrorSortParams
1111
from vika.datasheet.field_manager import FieldManager
1212
from vika.datasheet.record import Record
1313
from vika.datasheet.record_manager import RecordManager
@@ -87,13 +87,13 @@ def create_field(self, data) -> PostMetaFieldResponse:
8787
8888
:param dic data: api请求体,结构:{'type': str, 'name': str, 'property': obj}
8989
:return: 字段创建api返回结果
90-
:raises SpaceInfoLack: 缺少空间站信息
90+
:raises NameError: 缺少空间id信息
9191
:raises ServerError: 服务端错误
9292
:raises ResponseBodyParserError: 解析响应体失败
9393
:raises Exception: 其他异常,如:字段重名
9494
"""
9595
if self.spc_id is None:
96-
raise SpaceInfoLack("缺少空间信息")
96+
raise NameError('maybe: vika.datasheet("dst_id") => vika.space("spc_id").datasheet("dst_id")')
9797
api_endpoint = urljoin(self.vika.api_base,
9898
f"/fusion/v1/spaces/{self.spc_id}/datasheets/{self.id}/fields")
9999
resp = self.vika.request.post(api_endpoint, json=data)
@@ -104,13 +104,13 @@ def delete_field(self, field_id: str) -> bool:
104104
105105
:param str field_id: 字段id
106106
:return: 字段是否删除成功
107-
:raises SpaceInfoLack: 缺少空间站信息
107+
:raises NameError: 缺少空间id信息
108108
:raises ServerError: 服务端错误
109109
:raises ResponseBodyParserError: 解析响应体失败
110110
:raises Exception: 其他异常,如:
111111
"""
112112
if self.spc_id is None:
113-
raise SpaceInfoLack("缺少空间信息")
113+
raise NameError('maybe: vika.datasheet("dst_id") => vika.space("spc_id").datasheet("dst_id")')
114114
api_endpoint = urljoin(self.vika.api_base,
115115
f"/fusion/v1/spaces/{self.spc_id}/datasheets/{self.id}/fields/{field_id}")
116116
resp = self.vika.request.delete(api_endpoint)

vika/datasheet/datasheet_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ def create(self, data) -> PostDatasheetMetaResponseData:
1313
1414
:param dict data: 新建表格属性
1515
:return: 新建表格id、创建时间戳和字段id、name信息
16-
:raises SpaceInfoLack: 缺少空间站信息
16+
:raises NameError: 缺少空间id信息
1717
:raises ServerError: 服务端错误
1818
:raises ResponseBodyParserError: 解析响应体失败
1919
:raises Exception: 其他异常
2020
2121
:example:
2222
>>> vika = Vika('YOUR_API_TOKEN')
2323
>>> req_data = {'name': 'table_name'}
24-
>>> rep = vika.space('YOUR_SPACE_ID').datasheet.create(req_data)
24+
>>> rep = vika.space('YOUR_SPACE_ID').datasheets.create(req_data)
2525
"""
2626
resp = self.spc.create_datasheet(data)
2727
return resp.data

vika/datasheet/field_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def create(self, data) -> Optional[MetaField]:
8484
8585
:param dict data: 新建字段属性
8686
:return: 新建字段id和name
87-
:raises SpaceInfoLack: 缺少空间站信息
87+
:raises NameError: 缺少空间id信息
8888
:raises ServerError: 服务端错误
8989
:raises ResponseBodyParserError: 解析响应体失败
9090
:raises Exception: 其他异常,如:字段重名
@@ -105,7 +105,7 @@ def delete(self, fid_id: str) -> bool:
105105
106106
:param str fid_id: 要删除的字段信息
107107
:return: 删除成功返回ture
108-
:raises SpaceInfoLack: 缺少空间站信息
108+
:raises NameError: 缺少空间id信息
109109
:raises ServerError: 服务端错误
110110
:raises ResponseBodyParserError: 解析响应体失败
111111
:raises Exception: 其他异常,如:字段id不存在

vika/exceptions.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
class SpaceInfoLack(Exception):
2-
"""
3-
缺少空间站信息
4-
"""
5-
pass
6-
7-
81
class DatasheetDoesNotExist(Exception):
92
"""
103
数表不存在

vika/space/space.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from vika.datasheet import Datasheet, DatasheetManager
44
from vika.types.response import PostDatasheetMetaResponse
55
from urllib.parse import urljoin
6-
from vika.exceptions import SpaceInfoLack
76

87

98
class Space:
@@ -36,13 +35,13 @@ def create_datasheet(self, data) -> PostDatasheetMetaResponse:
3635
3736
:param dic data: api请求体,结构:{'name': 'table_name'}
3837
:return: 创建表格响应数据
39-
:raises SpaceInfoLack: 缺少空间站信息
38+
:raises NameError: 缺少空间id信息
4039
:raises ServerError: 服务端错误
4140
:raises ResponseBodyParserError: 解析响应体失败
4241
:raises Exception: 其他异常
4342
"""
4443
if self.id is None:
45-
raise SpaceInfoLack("缺少空间信息")
44+
raise NameError('maybe: vika.datasheet("dst_id") => vika.space("spc_id").datasheet("dst_id")')
4645
api_endpoint = urljoin(self.vika.api_base,
4746
f"/fusion/v1/spaces/{self.id}/datasheets")
4847
resp = self.vika.request.post(api_endpoint, json=data)

0 commit comments

Comments
 (0)