Do not allow empty StorageClass profile ID

This patch prevents a bug in the VMIC controller where an empty
profile ID slipped into locations due to the VM provider not
verifying the profile ID from a StorageClass is non-empty.

The VMIC API has also been updated to require a min-length of 1
for required fields.

Author: akutz

api/v1alpha5/virtualmachineimagecache_types.go

@@ -23,16 +23,26 @@ const (
 )
 
 type VirtualMachineImageCacheLocationSpec struct {
+
+	// +required
+	// +kubebuilder:validation:MinLength=1
+
 	// DatacenterID describes the ID of the datacenter to which the image should
 	// be cached.
 	DatacenterID string `json:"datacenterID"`
 
+	// +required
+	// +kubebuilder:validation:MinLength=1
+
 	// ProfileID describes the ID of the storage profile used to cache the
 	// image.
 	// Please note, this profile *must* include the datastore specified by the
 	// datastoreID field.
 	ProfileID string `json:"profileID"`
 
+	// +required
+	// +kubebuilder:validation:MinLength=1
+
 	// DatastoreID describes the ID of the datastore to which the image should
 	// be cached.
 	DatastoreID string `json:"datastoreID"`

config/crd/bases/vmoperator.vmware.com_virtualmachineimagecaches.yaml

@@ -664,18 +664,21 @@ spec:
                       description: |-
                         DatacenterID describes the ID of the datacenter to which the image should
                         be cached.
+                      minLength: 1
                       type: string
                     datastoreID:
                       description: |-
                         DatastoreID describes the ID of the datastore to which the image should
                         be cached.
+                      minLength: 1
                       type: string
                     profileID:
                       description: |-
                         ProfileID describes the ID of the storage profile used to cache the
                         image.
                         Please note, this profile *must* include the datastore specified by the
                         datastoreID field.
+                      minLength: 1
                       type: string
                   required:
                   - datacenterID

pkg/util/kube/storage.go

@@ -146,8 +146,8 @@ func (e ErrMissingParameter) Error() string {
 // GetStoragePolicyID returns the storage policy ID for a given StorageClass.
 // If no ID is found, an error is returned.
 func GetStoragePolicyID(obj storagev1.StorageClass) (string, error) {
-	policyID, ok := obj.Parameters[internal.StoragePolicyIDParameter]
-	if !ok {
+	policyID := obj.Parameters[internal.StoragePolicyIDParameter]
+	if policyID == "" {
 		return "", ErrMissingParameter{
 			StorageClassName: obj.Name,
 			ParameterName:    internal.StoragePolicyIDParameter,